You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ti...@apache.org on 2020/03/24 13:24:24 UTC
[cordova-plugin-inappbrowser] branch master updated: (android)
Added option to turn on/off fullscreen mode in Android (#634)
This is an automated email from the ASF dual-hosted git repository.
timbru31 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git
The following commit(s) were added to refs/heads/master by this push:
new e78ffe7 (android) Added option to turn on/off fullscreen mode in Android (#634)
e78ffe7 is described below
commit e78ffe7fc29902f1fee4ef1b0a6e836c2b9efa44
Author: PDLMobileApps <46...@users.noreply.github.com>
AuthorDate: Tue Mar 24 09:24:14 2020 -0400
(android) Added option to turn on/off fullscreen mode in Android (#634)
* (android) Added option to turn on/off fullscreen mode in Android
* (android) Reverted version changes as requested
* (android) Changing default option value to enabled as per request
Co-authored-by: Alessandro Basso <Al...@PeapodDigitalLabs.com>
---
README.md | 1 +
src/android/InAppBrowser.java | 10 +++++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index aa5da3d..fe5f754 100644
--- a/README.md
+++ b/README.md
@@ -128,6 +128,7 @@ instance, or the system browser.
- __mediaPlaybackRequiresUserAction__: Set to `yes` to prevent HTML5 audio or video from autoplaying (defaults to `no`).
- __shouldPauseOnSuspend__: Set to `yes` to make InAppBrowser WebView to pause/resume with the app to stop background audio (this may be required to avoid Google Play issues like described in [CB-11013](https://issues.apache.org/jira/browse/CB-11013)).
- __useWideViewPort__: Sets whether the WebView should enable support for the "viewport" HTML meta tag or should use a wide viewport. When the value of the setting is `no`, the layout width is always set to the width of the WebView control in device-independent (CSS) pixels. When the value is `yes` and the page contains the viewport meta tag, the value of the width specified in the tag is used. If the page does not contain the tag or does not provide a width, then a wide viewport wil [...]
+ - __fullscreen__: Sets whether the InappBrowser WebView is displayed fullscreen or not. In fullscreen mode, the status bar is hidden. Default value is `yes`.
iOS supports these additional options:
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index efec7ec..e2c16f9 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -117,6 +117,7 @@ public class InAppBrowser extends CordovaPlugin {
private static final String FOOTER = "footer";
private static final String FOOTER_COLOR = "footercolor";
private static final String BEFORELOAD = "beforeload";
+ private static final String FULLSCREEN = "fullscreen";
private static final List customizableOptions = Arrays.asList(CLOSE_BUTTON_CAPTION, TOOLBAR_COLOR, NAVIGATION_COLOR, CLOSE_BUTTON_COLOR, FOOTER_COLOR);
@@ -147,6 +148,7 @@ public class InAppBrowser extends CordovaPlugin {
private boolean showFooter = false;
private String footerColor = "";
private String beforeload = "";
+ private boolean fullscreen = true;
private String[] allowedSchemes;
private InAppBrowserClient currentClient;
@@ -714,6 +716,10 @@ public class InAppBrowser extends CordovaPlugin {
if (features.get(BEFORELOAD) != null) {
beforeload = features.get(BEFORELOAD);
}
+ String fullscreenSet = features.get(FULLSCREEN);
+ if (fullscreenSet != null) {
+ fullscreen = fullscreenSet.equals("yes") ? true : false;
+ }
}
final CordovaWebView thatWebView = this.webView;
@@ -794,7 +800,9 @@ public class InAppBrowser extends CordovaPlugin {
dialog = new InAppBrowserDialog(cordova.getActivity(), android.R.style.Theme_NoTitleBar);
dialog.getWindow().getAttributes().windowAnimations = android.R.style.Animation_Dialog;
dialog.requestWindowFeature(Window.FEATURE_NO_TITLE);
- dialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN, WindowManager.LayoutParams.FLAG_FULLSCREEN);
+ if (fullscreen) {
+ dialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN, WindowManager.LayoutParams.FLAG_FULLSCREEN);
+ }
dialog.setCancelable(true);
dialog.setInAppBroswer(getInAppBrowser());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org