[jira] [Work logged] (ARTEMIS-3568) fixes/improvements on the "Send message" screens

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3568?focusedWorklogId=696259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696259 ]

ASF GitHub Bot logged work on ARTEMIS-3568:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Dec/21 00:25
            Start Date: 15/Dec/21 00:25
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic merged pull request #3848:
URL: https://github.com/apache/activemq-artemis/pull/3848


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 696259)
    Time Spent: 20m  (was: 10m)

> fixes/improvements on the "Send message" screens
> ------------------------------------------------
>
>                 Key: ARTEMIS-3568
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3568
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: 2.19.0
>            Reporter: Erwin Dondorp
>            Priority: Minor
>         Attachments: screenshot-3.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The "Send message" screen has room for a few (sometimes minor) improvements. I've bundled them in one PR.
> * (fix) fixed delete-header-item on page send-message-to-queue due to broken js code behind the delete-button (caught by viewing the diff between addressSendMessage.js and sendMessage.js);
> * (fix) fixed format-message on page send-message-to-queue due to broken js code behind the format-button (this initially led me to believe that the button would apply syntax-color only, until I saw the intended behaviour on page send-message-to-address).
> all of the below change apply to both send-message-to-queue and send-message-to-address pages:
> * (smallfix) fixed small spelling error in a help-text where "in" was spelled as "ion";
> * (smallfix) fixed small spelling error in a help-text where "it's" was spelled as "its";
> * (cosmetic) the dropdown-box for the format selection has been shrunk and the button placed on the same line;
> * (cosmetic) renamed button from "Send message" to "Send Message", just because the "Add Header" button on the same page also uses capitals.
> I read that "CodeEditor" also supported YAML and TOML. But when I tried it out, the syntax colours only worked for YAML and the reformatting did not work for any of these two. so that part was dropped before it was even committed.
> note: internally there are 2 "Send message" screens. one to send a message to an address, the other one to send a message to a queue. these screen look very similar and have the same title and button name. the 2 screens can be only be distinguished visually by looking at the help text from the (?) button just after the page title. of course the one page is used when an address is selected in the tree; the other when a queue is selected in the tree.
> !screenshot-3.png!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)