You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Thomas Neidhart (JIRA)" <ji...@apache.org> on 2012/07/14 23:00:46 UTC
[jira] [Commented] (MATH-822) Unnecessary Parameter in
EigenDecomposition?
[ https://issues.apache.org/jira/browse/MATH-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414499#comment-13414499 ]
Thomas Neidhart commented on MATH-822:
--------------------------------------
Hi Jared,
well spotted. I think your proposal makes sense. I will also mark the other constructors as deprecated.
Thomas
> Unnecessary Parameter in EigenDecomposition?
> --------------------------------------------
>
> Key: MATH-822
> URL: https://issues.apache.org/jira/browse/MATH-822
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Jared Becksfort
> Priority: Minor
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> I am still new to the Commons Math code base, so I am sorry if this is a dumb question. I am browsing the code for EigenDecomposition, and both of its constructors have an unused parameter called splitTolerance. The comments indicate that this is for backward compatibility.
> Would it be acceptable for me to simply include a one-parameter constructor that calls the two-parameter one, so backward compatibility is preserved and client code no longer needs to provide a pointless double?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira