You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/09/23 11:32:17 UTC
[GitHub] [cassandra-dtest] XN137 opened a new pull request #96: remove redundant params for Cluster.start
XN137 opened a new pull request #96:
URL: https://github.com/apache/cassandra-dtest/pull/96
ever since https://github.com/riptano/ccm/pull/561 the defaults for `Cluster.start` have been:
`wait_for_binary_proto=True` and `wait_other_notice=True`.
still today:
https://github.com/riptano/ccm/blob/f6fd55a6bff53043d0c156480a72a7db6f477df5/ccmlib/cluster.py#L432-L433
so imo it makes sense to avoid specifying these redundant param values to shorten the code and also avoid confusion (because their presence could suggest that these are non-default values).
note that this is not true for `Node.start`:
https://github.com/riptano/ccm/blob/f6fd55a6bff53043d0c156480a72a7db6f477df5/ccmlib/node.py#L623-L632
so care was taken to only adjust `Cluster.start` places.
CI run:
https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/20/ :large_blue_circle:
potential followup:
`Node.start` defaults to `wait_other_notice=True` and a similar cleanup can be done there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] michaelsembwever merged pull request #96: remove redundant params for Cluster.start
Posted by GitBox <gi...@apache.org>.
michaelsembwever merged pull request #96:
URL: https://github.com/apache/cassandra-dtest/pull/96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org