You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2023/07/03 11:47:55 UTC
[kudu-CR] [docs] Update tablet server decommission documentation
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20153
Change subject: [docs] Update tablet server decommission documentation
......................................................................
[docs] Update tablet server decommission documentation
This patch adds a note about using `kudu tserver unregister` tool to
remove a dead tablet server from the cluster in newer Kudu versions.
Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
---
M docs/administration.adoc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/20153/1
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20153 )
Change subject: [docs] Update tablet server decommission documentation
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 15:00:30 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20153 )
Change subject: [docs] Update tablet server decommission documentation
......................................................................
[docs] Update tablet server decommission documentation
This patch updates the last step in tablet server decommission section,
mentioning using `kudu tserver unregister` tool to remove a dead tablet
server from the cluster in newer Kudu versions.
Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Reviewed-on: http://gerrit.cloudera.org:8080/20153
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M docs/administration.adoc
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
Marton Greber: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20153 )
Change subject: [docs] Update tablet server decommission documentation
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20153/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/20153/2/docs/administration.adoc@1614
PS2, Line 1614:
nit: Remove the extra space.
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jul 2023 09:51:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20153
to look at the new patch set (#3).
Change subject: [docs] Update tablet server decommission documentation
......................................................................
[docs] Update tablet server decommission documentation
This patch updates the last step in tablet server decommission section,
mentioning using `kudu tserver unregister` tool to remove a dead tablet
server from the cluster in newer Kudu versions.
Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
---
M docs/administration.adoc
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/20153/3
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20153
to look at the new patch set (#2).
Change subject: [docs] Update tablet server decommission documentation
......................................................................
[docs] Update tablet server decommission documentation
This patch updates the last step in tablet server decommission section,
mentioning using `kudu tserver unregister` tool to remove a dead tablet
server from the cluster in newer Kudu versions.
Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
---
M docs/administration.adoc
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/20153/2
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20153 )
Change subject: [docs] Update tablet server decommission documentation
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20153/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/20153/1/docs/administration.adoc@1614
PS1, Line 1614: run the `kudu tserver unregister` tool.
: +
: NOTE: From Kudu version 1.16.0 onward
> Because the current version (1.16.0) supports to use CLI tool to unregister
Done
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jul 2023 08:49:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20153 )
Change subject: [docs] Update tablet server decommission documentation
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jul 2023 12:22:03 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20153 )
Change subject: [docs] Update tablet server decommission documentation
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jul 2023 14:56:07 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20153 )
Change subject: [docs] Update tablet server decommission documentation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20153/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/20153/1/docs/administration.adoc@1614
PS1, Line 1614: restart the masters. In the case of a single master,
: this will cause cluster downtime. With multi-master, restart the masters in
: sequence to avoid cluster downtime.
Because the current version (1.16.0) supports to use CLI tool to unregister tserver without restarting masters, how about swapping the two sections, make the CLI tool method as default?
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jul 2023 16:09:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Update tablet server decommission documentation
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20153 )
Change subject: [docs] Update tablet server decommission documentation
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20153/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/20153/2/docs/administration.adoc@1614
PS2, Line 1614: r
> nit: Remove the extra space.
Done
--
To view, visit http://gerrit.cloudera.org:8080/20153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60043175ebdc0484ba655788aa7f5fb062e2a4ae
Gerrit-Change-Number: 20153
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jul 2023 12:03:55 +0000
Gerrit-HasComments: Yes