You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wangbo (via GitHub)" <gi...@apache.org> on 2024/04/16 12:53:37 UTC

[PR] [Refactor](executor)Add workload schedule policy table [doris]

wangbo opened a new pull request, #33729:
URL: https://github.com/apache/doris/pull/33729

   ## Proposed changes
   Add workload schedule policy table to instead of TVF workload_schedule_policy();
   ```
   
   mysql [information_schema]>desc workload_schedule_policy;
   +-----------+--------------+------+-------+---------+-------+
   | Field     | Type         | Null | Key   | Default | Extra |
   +-----------+--------------+------+-------+---------+-------+
   | ID        | BIGINT       | Yes  | false | NULL    |       |
   | NAME      | VARCHAR(256) | Yes  | false | NULL    |       |
   | CONDITION | TEXT         | Yes  | false | NULL    |       |
   | ACTION    | TEXT         | Yes  | false | NULL    |       |
   | PRIORITY  | INT          | Yes  | false | NULL    |       |
   | ENABLED   | BOOLEAN      | Yes  | false | NULL    |       |
   | VERSION   | INT          | Yes  | false | NULL    |       |
   +-----------+--------------+------+-------+---------+-------+
   7 rows in set (0.00 sec)
   
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #33729:
URL: https://github.com/apache/doris/pull/33729#discussion_r1568155178


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SchemaTableType.java:
##########
@@ -74,7 +74,11 @@ public enum SchemaTableType {
     SCH_ACTIVE_QUERIES("ACTIVE_QUERIES", "ACTIVE_QUERIES", TSchemaTableType.SCH_ACTIVE_QUERIES),
     SCH_WORKLOAD_GROUPS("WORKLOAD_GROUPS", "WORKLOAD_GROUPS", TSchemaTableType.SCH_WORKLOAD_GROUPS),
     SCHE_USER("user", "user", TSchemaTableType.SCH_USER),
-    SCH_PROCS_PRIV("procs_priv", "procs_priv", TSchemaTableType.SCH_PROCS_PRIV);
+    SCH_PROCS_PRIV("procs_priv", "procs_priv", TSchemaTableType.SCH_PROCS_PRIV),
+
+    SCH_WORKLOAD_SCHEDULE_POLICY("WORKLOAD_SCHEDULE_POLICY", "WORKLOAD_SCHEDULE_POLICY",
+            TSchemaTableType.SCH_WORKLOAD_SCHEDULE_POLICY);
+

Review Comment:
   And also delete related show proc code, we will not maintain show proc in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2063650637

   TeamCity be ut coverage result:
    Function Coverage: 35.42% (8913/25161) 
    Line Coverage: 27.12% (73229/270042)
    Region Coverage: 26.25% (37834/144146)
    Branch Coverage: 23.04% (19274/83642)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/4a1692306e5594fa78c60e1dad95f6973a9fb85a_4a1692306e5594fa78c60e1dad95f6973a9fb85a/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2063843447

   TeamCity be ut coverage result:
    Function Coverage: 35.42% (8913/25161) 
    Line Coverage: 27.12% (73228/270045)
    Region Coverage: 26.25% (37835/144146)
    Branch Coverage: 23.05% (19278/83642)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/9255754e4bc1281843a2ef14bfd42783d8356426_9255754e4bc1281843a2ef14bfd42783d8356426/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2063427732

   TeamCity be ut coverage result:
    Function Coverage: 35.42% (8913/25161) 
    Line Coverage: 27.12% (73227/270042)
    Region Coverage: 26.24% (37826/144146)
    Branch Coverage: 23.04% (19273/83642)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/73607517433d3ae07a18a8a09820247e4e0b6dff_73607517433d3ae07a18a8a09820247e4e0b6dff/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2063609658

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #33729:
URL: https://github.com/apache/doris/pull/33729#discussion_r1567317380


##########
be/src/exec/schema_scanner/schema_workload_sched_policy_scanner.cpp:
##########
@@ -0,0 +1,136 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_workload_sched_policy_scanner.h"
+
+#include "runtime/client_cache.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "util/thrift_rpc_helper.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+#include "vec/data_types/data_type_factory.hpp"
+
+namespace doris {
+std::vector<SchemaScanner::ColumnDesc> SchemaWorkloadSchedulePolicyScanner::_s_tbls_columns = {
+        {"ID", TYPE_BIGINT, sizeof(int64_t), true},
+        {"NAME", TYPE_VARCHAR, sizeof(StringRef), true},
+        {"CONDITION", TYPE_STRING, sizeof(StringRef), true},
+        {"ACTION", TYPE_STRING, sizeof(StringRef), true},
+        {"PRIORITY", TYPE_INT, sizeof(int32_t), true},
+        {"ENABLED", TYPE_BOOLEAN, sizeof(bool), true},
+        {"VERSION", TYPE_INT, sizeof(int32_t), true},
+};
+
+SchemaWorkloadSchedulePolicyScanner::SchemaWorkloadSchedulePolicyScanner()
+        : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_SCHEDULE_POLICY) {}
+
+SchemaWorkloadSchedulePolicyScanner::~SchemaWorkloadSchedulePolicyScanner() {}

Review Comment:
   warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
   
   ```suggestion
   SchemaWorkloadSchedulePolicyScanner::~SchemaWorkloadSchedulePolicyScanner() = default;
   ```
   



##########
be/src/exec/schema_scanner/schema_workload_sched_policy_scanner.cpp:
##########
@@ -0,0 +1,136 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_workload_sched_policy_scanner.h"
+
+#include "runtime/client_cache.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "util/thrift_rpc_helper.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+#include "vec/data_types/data_type_factory.hpp"
+
+namespace doris {
+std::vector<SchemaScanner::ColumnDesc> SchemaWorkloadSchedulePolicyScanner::_s_tbls_columns = {
+        {"ID", TYPE_BIGINT, sizeof(int64_t), true},
+        {"NAME", TYPE_VARCHAR, sizeof(StringRef), true},
+        {"CONDITION", TYPE_STRING, sizeof(StringRef), true},
+        {"ACTION", TYPE_STRING, sizeof(StringRef), true},
+        {"PRIORITY", TYPE_INT, sizeof(int32_t), true},
+        {"ENABLED", TYPE_BOOLEAN, sizeof(bool), true},
+        {"VERSION", TYPE_INT, sizeof(int32_t), true},
+};
+
+SchemaWorkloadSchedulePolicyScanner::SchemaWorkloadSchedulePolicyScanner()

Review Comment:
   warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
   
   be/src/exec/schema_scanner/schema_workload_sched_policy_scanner.cpp:39:
   ```diff
   -         : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_SCHEDULE_POLICY) {}
   +         : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_SCHEDULE_POLICY) = default;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #33729:
URL: https://github.com/apache/doris/pull/33729#discussion_r1568115778


##########
be/src/exec/schema_scanner.h:
##########
@@ -17,6 +17,7 @@
 
 #pragma once
 
+#include <gen_cpp/Data_types.h>

Review Comment:
   warning: 'gen_cpp/Data_types.h' file not found [clang-diagnostic-error]
   ```cpp
   #include <gen_cpp/Data_types.h>
            ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2063061254

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2060262061

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38512 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 09896be958b987847978b6e6d959166b51a0f69a, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17606	4976	4224	4224
   q2	2019	192	184	184
   q3	10446	1131	1223	1131
   q4	10190	682	857	682
   q5	7523	2741	2579	2579
   q6	214	132	130	130
   q7	1026	597	594	594
   q8	9226	2094	2089	2089
   q9	7286	6651	6549	6549
   q10	8613	3562	3542	3542
   q11	461	233	232	232
   q12	456	218	218	218
   q13	17767	2926	2948	2926
   q14	273	229	236	229
   q15	518	497	483	483
   q16	515	404	378	378
   q17	964	717	696	696
   q18	7458	6925	6857	6857
   q19	4721	1483	1506	1483
   q20	648	310	311	310
   q21	3493	2797	2687	2687
   q22	378	314	309	309
   Total cold run time: 111801 ms
   Total hot run time: 38512 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4311	4242	4220	4220
   q2	385	259	269	259
   q3	3021	2748	2784	2748
   q4	1854	1644	1574	1574
   q5	5338	5310	5321	5310
   q6	205	127	123	123
   q7	2287	1873	1908	1873
   q8	3229	3366	3336	3336
   q9	8626	8587	8588	8587
   q10	4144	3930	3988	3930
   q11	606	509	498	498
   q12	813	634	649	634
   q13	17162	3181	3141	3141
   q14	317	269	298	269
   q15	530	480	476	476
   q16	508	456	428	428
   q17	1865	1554	1511	1511
   q18	8198	8255	7859	7859
   q19	1683	1566	1622	1566
   q20	2074	1877	1844	1844
   q21	5279	4897	4916	4897
   q22	553	474	463	463
   Total cold run time: 72988 ms
   Total hot run time: 55546 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2060270342

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 185813 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 09896be958b987847978b6e6d959166b51a0f69a, data reload: false
   
   query1	887	381	376	376
   query2	6180	2727	2355	2355
   query3	6679	198	198	198
   query4	23415	21386	21330	21330
   query5	4130	401	402	401
   query6	292	188	176	176
   query7	4579	289	286	286
   query8	228	182	185	182
   query9	8419	2356	2353	2353
   query10	418	253	244	244
   query11	14825	14363	14193	14193
   query12	132	89	87	87
   query13	1633	354	361	354
   query14	9705	7640	7991	7640
   query15	265	177	180	177
   query16	8064	259	264	259
   query17	1926	575	532	532
   query18	1833	276	270	270
   query19	254	141	144	141
   query20	94	83	84	83
   query21	195	124	123	123
   query22	5033	4854	4845	4845
   query23	33804	33290	33340	33290
   query24	10576	3114	3173	3114
   query25	606	384	409	384
   query26	721	158	160	158
   query27	2385	365	379	365
   query28	5808	2101	2109	2101
   query29	901	641	631	631
   query30	266	188	186	186
   query31	1001	771	801	771
   query32	93	53	52	52
   query33	667	263	247	247
   query34	902	490	506	490
   query35	852	713	735	713
   query36	1100	959	964	959
   query37	107	73	73	73
   query38	3530	3345	3302	3302
   query39	1642	1603	1576	1576
   query40	178	134	133	133
   query41	45	41	60	41
   query42	99	97	94	94
   query43	582	522	550	522
   query44	1078	735	730	730
   query45	305	289	268	268
   query46	1115	753	753	753
   query47	2051	1961	2004	1961
   query48	381	300	290	290
   query49	887	391	383	383
   query50	765	392	386	386
   query51	6860	6720	6792	6720
   query52	103	84	87	84
   query53	341	268	276	268
   query54	296	223	228	223
   query55	74	71	71	71
   query56	242	219	219	219
   query57	1237	1138	1133	1133
   query58	216	194	199	194
   query59	3429	3109	3013	3013
   query60	259	229	228	228
   query61	89	90	86	86
   query62	588	449	444	444
   query63	302	275	271	271
   query64	4749	4055	3685	3685
   query65	3060	3361	3008	3008
   query66	750	336	322	322
   query67	15582	15149	15103	15103
   query68	5236	523	527	523
   query69	519	291	306	291
   query70	1260	1178	1190	1178
   query71	1392	1263	1263	1263
   query72	6442	2640	2440	2440
   query73	703	322	317	317
   query74	6807	6439	6520	6439
   query75	3453	2615	2574	2574
   query76	3222	971	977	971
   query77	619	258	302	258
   query78	10841	10220	10173	10173
   query79	8126	507	506	506
   query80	1716	454	440	440
   query81	529	245	242	242
   query82	955	101	95	95
   query83	333	160	161	160
   query84	263	84	86	84
   query85	1635	266	255	255
   query86	468	294	313	294
   query87	3530	3287	3297	3287
   query88	5298	2413	2413	2413
   query89	477	372	364	364
   query90	1869	181	183	181
   query91	122	94	95	94
   query92	55	47	48	47
   query93	6439	496	490	490
   query94	1046	176	181	176
   query95	385	298	306	298
   query96	597	271	266	266
   query97	3123	2974	2980	2974
   query98	228	210	212	210
   query99	1250	882	860	860
   Total cold run time: 288748 ms
   Total hot run time: 185813 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2063206193

   TeamCity be ut coverage result:
    Function Coverage: 35.43% (8913/25160) 
    Line Coverage: 27.12% (73230/270038)
    Region Coverage: 26.24% (37828/144143)
    Branch Coverage: 23.05% (19278/83638)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/f235ebb575834401e2ca4648a8f1b734dc65e058_f235ebb575834401e2ca4648a8f1b734dc65e058/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2060200329

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2067021769

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2063810044

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2060173626

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2060276185

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 09896be958b987847978b6e6d959166b51a0f69a with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
   Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2060274035

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 29.88 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 09896be958b987847978b6e6d959166b51a0f69a, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.03	0.04
   query3	0.23	0.05	0.05
   query4	1.73	0.06	0.06
   query5	0.49	0.48	0.51
   query6	1.48	0.72	0.71
   query7	0.02	0.02	0.01
   query8	0.05	0.04	0.04
   query9	0.54	0.50	0.51
   query10	0.55	0.55	0.55
   query11	0.16	0.12	0.11
   query12	0.15	0.12	0.12
   query13	0.61	0.59	0.59
   query14	0.77	0.80	0.79
   query15	0.81	0.81	0.80
   query16	0.36	0.35	0.35
   query17	0.95	0.96	0.97
   query18	0.19	0.24	0.23
   query19	1.76	1.66	1.65
   query20	0.01	0.01	0.01
   query21	15.39	0.64	0.64
   query22	4.33	7.87	1.51
   query23	18.21	1.41	1.34
   query24	1.71	0.31	0.23
   query25	0.15	0.08	0.09
   query26	0.26	0.17	0.16
   query27	0.09	0.08	0.08
   query28	13.29	0.99	0.98
   query29	12.63	3.25	3.24
   query30	0.26	0.06	0.06
   query31	2.86	0.39	0.38
   query32	3.26	0.45	0.47
   query33	2.87	2.78	2.87
   query34	17.20	4.41	4.40
   query35	4.48	4.48	4.46
   query36	0.64	0.46	0.45
   query37	0.18	0.15	0.15
   query38	0.16	0.15	0.14
   query39	0.04	0.03	0.04
   query40	0.17	0.14	0.15
   query41	0.09	0.04	0.04
   query42	0.06	0.04	0.05
   query43	0.04	0.04	0.03
   Total cold run time: 109.35 s
   Total hot run time: 29.88 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2059023292

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2060279805

   TeamCity be ut coverage result:
    Function Coverage: 35.50% (8908/25096) 
    Line Coverage: 27.21% (73149/268800)
    Region Coverage: 26.34% (37818/143596)
    Branch Coverage: 23.12% (19272/83370)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/09896be958b987847978b6e6d959166b51a0f69a_09896be958b987847978b6e6d959166b51a0f69a/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2063370802

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo merged PR #33729:
URL: https://github.com/apache/doris/pull/33729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](executor)Add workload schedule policy table [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33729:
URL: https://github.com/apache/doris/pull/33729#issuecomment-2067021820

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org