You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/25 20:50:50 UTC

[GitHub] [spark] martin-g commented on a change in pull request #35627: [SPARK-38302][K8S][TESTS] Use `Java 17` in K8S IT in case of `spark-tgz` option

martin-g commented on a change in pull request #35627:
URL: https://github.com/apache/spark/pull/35627#discussion_r815146505



##########
File path: resource-managers/kubernetes/integration-tests/scripts/setup-integration-test-env.sh
##########
@@ -106,7 +106,11 @@ then
     # OpenJDK base-image tag (e.g. 8-jre-slim, 11-jre-slim)
     JAVA_IMAGE_TAG_BUILD_ARG="-b java_image_tag=$JAVA_IMAGE_TAG"
   else
-    JAVA_IMAGE_TAG_BUILD_ARG="-f $DOCKER_FILE_BASE_PATH$DOCKER_FILE"
+    if [[ $DOCKER_FILE = /* ]]; then

Review comment:
       another way could be to use `if [[ -f $DOCKER_FILE ]]`, i.e. to check that the file exists or not




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org