You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/04 22:52:23 UTC

[GitHub] [beam] robertwb commented on a change in pull request #11894: [BEAM-7074] Enable test_pardo_timers_clear for fn_runner

robertwb commented on a change in pull request #11894:
URL: https://github.com/apache/beam/pull/11894#discussion_r435595283



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
##########
@@ -377,11 +377,6 @@ def process_timer(
       assert_that(actual, equal_to(expected))
 
   def test_pardo_timers_clear(self):
-    if type(self).__name__ != 'FlinkRunnerTest':

Review comment:
       I think it would be cleaner to add an override in the subclasses than test on `__name__` here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org