You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/20 19:08:09 UTC

[GitHub] [arrow] save-buffer commented on a diff in pull request #13651: ARROW-17087: [C++] Race condition in scanner test

save-buffer commented on code in PR #13651:
URL: https://github.com/apache/arrow/pull/13651#discussion_r925959617


##########
cpp/src/arrow/util/async_util.cc:
##########
@@ -105,15 +105,16 @@ Status AsyncTaskGroup::AddTask(const Future<>& task_fut) {
   return AddTaskUnlocked(task_fut, std::move(guard));
 }
 
-Status AsyncTaskGroup::AddTaskIfNotEnded(const Future<>& task_fut) {
+Result<bool> AsyncTaskGroup::AddTaskIfNotEnded(const Future<>& task_fut) {

Review Comment:
   Can you also update the interface of the overload of `AddTaskIfNotEnded` to return a bool?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org