You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/27 10:36:26 UTC
[GitHub] [dolphinscheduler] sneh-wha opened a new pull request, #10637: Doc change subprocess dependent
sneh-wha opened a new pull request, #10637:
URL: https://github.com/apache/dolphinscheduler/pull/10637
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10637: Doc change subprocess dependent
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10637:
URL: https://github.com/apache/dolphinscheduler/pull/10637#discussion_r907279300
##########
docs/docs/en/guide/task/dependent.md:
##########
@@ -7,20 +7,24 @@ Dependent nodes are **dependency check nodes**. For example, process A depends o
## Create Task
-- Click `Project -> Management-Project -> Name-Workflow Definition`, and click the `Create Workflow` button to enter the DAG editing page.
+- Click `Project Management -> Project Name -> Workflow Definition`, and click the `Create Workflow` button to enter the DAG editing page.
Review Comment:
Hi @SbloodyS , I think @sneh-wha can not both read and write Chinese docs. So maybe we should jus ignore the Chinese doc and only change the English one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10637: Doc change subprocess dependent
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10637:
URL: https://github.com/apache/dolphinscheduler/pull/10637#discussion_r907246249
##########
docs/docs/en/guide/task/dependent.md:
##########
@@ -7,20 +7,24 @@ Dependent nodes are **dependency check nodes**. For example, process A depends o
## Create Task
-- Click `Project -> Management-Project -> Name-Workflow Definition`, and click the `Create Workflow` button to enter the DAG editing page.
+- Click `Project Management -> Project Name -> Workflow Definition`, and click the `Create Workflow` button to enter the DAG editing page.
Review Comment:
Please also add chinese's doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10637: Doc change subprocess dependent
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10637:
URL: https://github.com/apache/dolphinscheduler/pull/10637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org