You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/06/15 12:31:15 UTC

[GitHub] flink pull request #2106: [FLINK-4063] Add Metrics Support for Triggers

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/2106

    [FLINK-4063] Add Metrics Support for Triggers

    R: @zentol for review. Is this the right way to do it?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink trigger/metrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2106
    
----
commit 2efb91464962100a06eae1b49805cbe5ee659022
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-06-15T12:30:06Z

    [FLINK-4063] Add Metrics Support for Triggers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2106: [FLINK-4063] Add Metrics Support for Triggers

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2106
  
    Ok, good to know. I'll change it. \U0001f603 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2106: [FLINK-4063] Add Metrics Support for Triggers

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2106
  
    well it would work, but i think we can improve it a little. :)
    
    The AbstractStreamOperator contains a protected MetricGroup field which you can use in the WindowOperator instead of going through the RuntimeContext. You can access it directly or via getMetricGroup().
    
    Also, you create 2 groups with a constant name. This means that all metrics that are registered in a trigger now contain "WindowOperator.Trigger" in their final metric name.
    
    Now the Trigger group is probably _fine_, but is now also mandatory. I would prefer removing it; if users want to group their metrics by Trigger they can easily do so themselves.
    
    The WindowOperator group should be removed. It is inconsistent with other operators and provides no really specific information. It will usually be redundant since the operator name often contains the String "window" somewhere.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2106: [FLINK-4063] Add Metrics Support for Triggers

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2106
  
    +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2106: [FLINK-4063] Add Metrics Support for Triggers

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha closed the pull request at:

    https://github.com/apache/flink/pull/2106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2106: [FLINK-4063] Add Metrics Support for Triggers

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2106
  
    @zentol updated, this is super minimal now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---