You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/28 19:26:22 UTC
[GitHub] [camel-k] tobiasoort opened a new pull request, #3855: Added support for multi-arch building of Operator image
tobiasoort opened a new pull request, #3855:
URL: https://github.com/apache/camel-k/pull/3855
<!-- Description -->
Adds multi-arch support in the Camel-K Operator docker image.
- Parameterized (defaults to amd64 + arm64)
- Uses the `ubi-quarkus-mandrel-builder-image` base instead of the `ubi-quarkus-mandrel` one
Fixes #1238 ; This should allow the Operator image to run natively on Apple Sillicon and other arm64 based processors.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
Camel-K Operator Container Image is now available in multi-arch flavour; support for linux/amd64 and linux/arm64.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tobiasoort commented on pull request #3855: Added support for multi-arch building of Operator image
Posted by GitBox <gi...@apache.org>.
tobiasoort commented on PR #3855:
URL: https://github.com/apache/camel-k/pull/3855#issuecomment-1330218963
One test failed, due to:
```
Expected
[3114](https://github.com/apache/camel-k/actions/runs/3567995319/jobs/6001875342#step:4:3256)
<string>:
[3115](https://github.com/apache/camel-k/actions/runs/3567995319/jobs/6001875342#step:4:3257)
to equal
[3116](https://github.com/apache/camel-k/actions/runs/3567995319/jobs/6001875342#step:4:3258)
<string>: \"\"
```
I'm pretty sure that's a bug in that test with some escaping gone awry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tobiasoort commented on pull request #3855: Added support for multi-arch building of Operator image
Posted by GitBox <gi...@apache.org>.
tobiasoort commented on PR #3855:
URL: https://github.com/apache/camel-k/pull/3855#issuecomment-1330289586
> FYI #3804 is related to this. The Camel K images stopped working for me because of the multi-arch changes made before. For me the wrong kamel CLI binary has been added to the image on MacOS aarch64.
> don't get me wrong this is not related to changes in this PR in particular but to multi-arch build in general
Yep, quite possible. I can check out the Camel CLI build (this is the Operator) after this! Would love to help out over there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tobiasoort commented on pull request #3855: Added support for multi-arch building of Operator image
Posted by GitBox <gi...@apache.org>.
tobiasoort commented on PR #3855:
URL: https://github.com/apache/camel-k/pull/3855#issuecomment-1330209521
> Why do we need to also make `make images` multi-arch even though we already have `make images-arch` which obviously builds images for multi-arch?
A couple of reasons! First of all, because 'it is the way'. Users expect dockerimages to be multi-arch and not ponder about what arch their system/cluster is on. Even the upstream containers like `ubi-quarkus-mandrel-builder-image` do this.
Second, because it allows you to think about the _pipeline_ and not about specific arch builds. This also means that this multi-arch image would get pushed to dockerhub, 'business as usual'.
Third: the multi-arch build depends on graalvm instead of quarkus (https://github.com/apache/camel-k/blob/3be0ab83ac6682c2412319a5778167d9dec08671/build/Dockerfile.arch#L16) because the right upstream image 'just for arm64' isnt there. This puts a split in the project dependencies and can cause weird issues downstream that are hard to reproduce.
My suggestion would be to remove the 'images-arch' after this PR. It was a good way to get all the plumbing in place, but with official docker support for multi-arch and also upstream support from quarkus, we don't need that 'fork in the road' anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on pull request #3855: Added support for multi-arch building of Operator image
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3855:
URL: https://github.com/apache/camel-k/pull/3855#issuecomment-1447329127
This PR has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #3855: Added support for multi-arch building of Operator image
Posted by GitBox <gi...@apache.org>.
christophd commented on PR #3855:
URL: https://github.com/apache/camel-k/pull/3855#issuecomment-1330247231
don't get me wrong this is not related to changes in this PR in particular but to multi-arch build in general
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #3855: Added support for multi-arch building of Operator image
Posted by GitBox <gi...@apache.org>.
christophd commented on PR #3855:
URL: https://github.com/apache/camel-k/pull/3855#issuecomment-1330245812
FYI https://github.com/apache/camel-k/pull/3804 is related to this. The Camel K images stopped working for me because of the multi-arch changes made before. For me the wrong kamel CLI binary has been added to the image on MacOS aarch64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] closed pull request #3855: Added support for multi-arch building of Operator image
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3855: Added support for multi-arch building of Operator image
URL: https://github.com/apache/camel-k/pull/3855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org