You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@slider.apache.org by te...@apache.org on 2014/06/27 18:29:37 UTC
git commit: SLIDER-173 Container requests for the same role should
utilize different nodes - add more logs
Repository: incubator-slider
Updated Branches:
refs/heads/develop 736a9c7e8 -> 581c182be
SLIDER-173 Container requests for the same role should utilize different nodes - add more logs
Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/581c182b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/581c182b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/581c182b
Branch: refs/heads/develop
Commit: 581c182beccc24bbc720b363ba42ea927b09e84f
Parents: 736a9c7
Author: tedyu <yu...@gmail.com>
Authored: Fri Jun 27 09:29:32 2014 -0700
Committer: tedyu <yu...@gmail.com>
Committed: Fri Jun 27 09:29:32 2014 -0700
----------------------------------------------------------------------
.../org/apache/slider/server/appmaster/state/RoleHistory.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/581c182b/slider-core/src/main/java/org/apache/slider/server/appmaster/state/RoleHistory.java
----------------------------------------------------------------------
diff --git a/slider-core/src/main/java/org/apache/slider/server/appmaster/state/RoleHistory.java b/slider-core/src/main/java/org/apache/slider/server/appmaster/state/RoleHistory.java
index 990d735..0cd2b39 100644
--- a/slider-core/src/main/java/org/apache/slider/server/appmaster/state/RoleHistory.java
+++ b/slider-core/src/main/java/org/apache/slider/server/appmaster/state/RoleHistory.java
@@ -406,6 +406,7 @@ public class RoleHistory {
for (int i = 0; i < roleSize; i++) {
NodeEntry nodeEntry = ni.get(i);
if (nodeEntry != null && nodeEntry.isAvailable()) {
+ log.debug("Adding {} for role {}", ni, i);
getOrCreateNodesForRoleId(i).add(ni);
}
}
@@ -470,7 +471,7 @@ public class RoleHistory {
List<NodeInstance> targets = getNodesForRoleId(roleKey);
int cnt = targets == null ? 0 : targets.size();
- Log.info("There're " + cnt + " nodes to consider for " + role.getName());
+ log.info("There're {} nodes to consider for {}", cnt, role.getName());
while (targets != null && !targets.isEmpty() && nodeInstance == null) {
NodeInstance head = targets.remove(0);
if (head.getActiveRoleInstances(roleKey) == 0) {
@@ -478,7 +479,7 @@ public class RoleHistory {
}
}
if (nodeInstance == null) {
- Log.debug("No node selected for " + role.getName());
+ log.debug("No node selected for {}", role.getName());
}
return nodeInstance;
}
@@ -597,6 +598,7 @@ public class RoleHistory {
hosts = outstandingRequests.cancelOutstandingRequests(role);
if (!hosts.isEmpty()) {
//add the list
+ log.debug("Adding {} hosts for role {}", hosts.size(), role);
getOrCreateNodesForRoleId(role).addAll(hosts);
sortAvailableNodeList(role);
}