[GitHub] nicolaferraro commented on a change in pull request #350: fix openapi handling when used in conjunction with deployment.container-image=true

[GitBox <gi...@apache.org>]

nicolaferraro commented on a change in pull request #350: fix openapi handling when used in conjunction with deployment.container-image=true
URL: https://github.com/apache/camel-k/pull/350#discussion_r249460162
 
 

 ##########
 File path: pkg/platform/platform.go
 ##########
 @@ -32,12 +32,12 @@ import (
 var gBuilder builder.Builder
 
 // GetPlatformBuilder --
-func GetPlatformBuilder(ctx context.Context, c client.Client, namespace string) (builder.Builder, error) {
+func GetPlatformBuilder(c client.Client, namespace string) (builder.Builder, error) {
 	if gBuilder != nil {
 		return gBuilder, nil
 	}
 
-	gBuilder = builder.New(ctx, c, namespace)
+	gBuilder = builder.New(context.TODO(), c, namespace)
 
 Review comment:
   Why creating a temp one and not propagating the existing one? You can pass a context.TODO if a context is not available at caller site. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services