You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/03/06 20:20:49 UTC

Review Request 18857: [HELIX-394] Make cluster event thread a daemon thread

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18857/
-----------------------------------------------------------

Review request for helix, Zhen Zhang and Kishore Gopalakrishna.


Bugs: HELIX-394


Repository: helix-git


Description
-------

commit 6a2a5f67cd2b1791f74a2439822647470740274b
Author: Kanak Biscuitwala <ka...@apache.org>
Date:   Thu Mar 6 11:19:09 2014 -0800

    [HELIX-394] Make cluster event thread a daemon thread

:100644 100644 b11ab9c... c8b033e... M	helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java


Diffs
-----

  helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java b11ab9c 

Diff: https://reviews.apache.org/r/18857/diff/


Testing
-------

Tests pass locally.


Thanks,

Kanak Biscuitwala


Re: Review Request 18857: [HELIX-394] Make cluster event thread a daemon thread

Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18857/#review36414
-----------------------------------------------------------

Ship it!


- Zhen Zhang


On March 6, 2014, 7:20 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18857/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 7:20 p.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-394
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 6a2a5f67cd2b1791f74a2439822647470740274b
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date:   Thu Mar 6 11:19:09 2014 -0800
> 
>     [HELIX-394] Make cluster event thread a daemon thread
> 
> :100644 100644 b11ab9c... c8b033e... M	helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
> 
> 
> Diffs
> -----
> 
>   helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java b11ab9c 
> 
> Diff: https://reviews.apache.org/r/18857/diff/
> 
> 
> Testing
> -------
> 
> Tests pass locally.
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>