You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/05 00:27:25 UTC
[jira] [Commented] (NIFI-1728) PutKafka tests need to explicitly
set charsets to be more portable
[ https://issues.apache.org/jira/browse/NIFI-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225188#comment-15225188 ]
ASF GitHub Bot commented on NIFI-1728:
--------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/325
NIFI-1728
NIFI-1728 Specifying charsets for messages sent to/received from Kafka in TestPutKafka to remedy failures in Windows environments. Specifying EOF as an int instead of a byte.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi TestPutKafkaFixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/325.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #325
----
----
> PutKafka tests need to explicitly set charsets to be more portable
> ------------------------------------------------------------------
>
> Key: NIFI-1728
> URL: https://issues.apache.org/jira/browse/NIFI-1728
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Witt
> Assignee: Aldrin Piri
> Fix For: 0.7.0, 0.6.1
>
>
> {quote}
> Tests run: 6, Failures: 3, Errors: 0, Skipped: 2, Time elapsed: 26.691 sec <<< FAILURE! - in org.apache.nifi.processors.kafka.TestPutK afka
> testComplexRightPartialDelimitedMessages(org.apache.nifi.processors.kafka.TestPutKafka) Time elapsed: 5.276 sec <<< FAILURE!
> org.junit.ComparisonFailure: expected:<Hello World[]> but was:<Hello World[?<?WILDSTUFF?>?Goodbye?<?WILDSTUFF?>?I Mean IT!?<?WILDSTUFF ?>]>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at org.apache.nifi.processors.kafka.TestPutKafka.testComplexRightPartialDelimitedMessages(TestPutKafka.java:206)
> testComplexPartialMatchDelimitedMessages(org.apache.nifi.processors.kafka.TestPutKafka) Time elapsed: 5.269 sec <<< FAILURE!
> org.junit.ComparisonFailure: expected:<Hello World[]> but was:<Hello World[?<?WILDSTUFF?>?Goodbye?<?WILDBOOMSTUFF?>?]>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at org.apache.nifi.processors.kafka.TestPutKafka.testComplexPartialMatchDelimitedMessages(TestPutKafka.java:249)
> testComplexLeftPartialDelimitedMessages(org.apache.nifi.processors.kafka.TestPutKafka) Time elapsed: 5.33 sec <<< FAILURE!
> org.junit.ComparisonFailure: expected:<Hello World[]> but was:<Hello World[?<?WILDSTUFF?>?Goodbye?<?WILDSTUFF?>?I Mean IT!?<?WILDSTUFF ?>?<?WILDSTUFF?>?]>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at org.apache.nifi.processors.kafka.TestPutKafka.testComplexLeftPartialDelimitedMessages(TestPutKafka.java:227)
> Results :
> Failed tests:
> KafkaPublisherTest.validateWithMultiByteCharacters:196 expected:<[?THIS IS MY NEW TEXT.?]IT HAS A NEWLINE.> but was:<[?THIS IS MY NE W TEXT.?]IT HAS A NEWLINE.>
> TestPutKafka.testComplexLeftPartialDelimitedMessages:227 expected:<Hello World[]> but was:<Hello World[?<?WILDSTUFF?>?Goodbye?<?WILD STUFF?>?I Mean IT!?<?WILDSTUFF?>?<?WILDSTUFF?>?]>
> TestPutKafka.testComplexPartialMatchDelimitedMessages:249 expected:<Hello World[]> but was:<Hello World[?<?WILDSTUFF?>?Goodbye?<?WIL DBOOMSTUFF?>?]>
> TestPutKafka.testComplexRightPartialDelimitedMessages:206 expected:<Hello World[]> but was:<Hello World[?<?WILDSTUFF?>?Goodbye?<?WIL DSTUFF?>?I Mean IT!?<?WILDSTUFF?>]>
> {quote}
> it appears we must set the charset to be used for input and we must set the charset to be used for comparison of all output. WIthout it the default charset is used and if the characters don't map cleanly then demarcation won't hit as it should.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)