You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datafu.apache.org by Jacob Tolar <de...@sheckel.net> on 2017/06/23 18:57:37 UTC
Review Request 60396: DATAFU-124 sessionize() ought to support
millisecond periods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60396/
-----------------------------------------------------------
Review request for DataFu.
Repository: datafu
Description
-------
DATAFU-124 sessionize() ought to support millisecond periods
Update Sessionize() and SessionCount() constructor to support millisecond second duration.
Refactored tests for those two UDFs and added a couple new ones.
I can revert the test refactor if that's cluttering things too much.
Diffs
-----
datafu-pig/src/main/java/datafu/pig/sessions/SessionCount.java fe68888
datafu-pig/src/main/java/datafu/pig/sessions/Sessionize.java d81fb48
datafu-pig/src/test/java/datafu/test/pig/sessions/SessionTests.java 76ec1d3
Diff: https://reviews.apache.org/r/60396/diff/1/
Testing
-------
./gradlew :datafu-pig:test
Thanks,
Jacob Tolar
Re: Review Request 60396: DATAFU-124 sessionize() ought to support
millisecond periods
Posted by Eyal Allweil via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60396/#review179112
-----------------------------------------------------------
Ship it!
It looks good. The tests are definitely improved - it's easier to understand conceptually what each one is checking.
- Eyal Allweil
On June 23, 2017, 9:57 p.m., Jacob Tolar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60396/
> -----------------------------------------------------------
>
> (Updated June 23, 2017, 9:57 p.m.)
>
>
> Review request for DataFu.
>
>
> Repository: datafu
>
>
> Description
> -------
>
> DATAFU-124 sessionize() ought to support millisecond periods
>
> Update Sessionize() and SessionCount() constructor to support millisecond second duration.
> Refactored tests for those two UDFs and added a couple new ones.
>
> I can revert the test refactor if that's cluttering things too much.
>
>
> Diffs
> -----
>
> datafu-pig/src/main/java/datafu/pig/sessions/SessionCount.java fe68888
> datafu-pig/src/main/java/datafu/pig/sessions/Sessionize.java d81fb48
> datafu-pig/src/test/java/datafu/test/pig/sessions/SessionTests.java 76ec1d3
>
>
> Diff: https://reviews.apache.org/r/60396/diff/1/
>
>
> Testing
> -------
>
> ./gradlew :datafu-pig:test
>
>
> Thanks,
>
> Jacob Tolar
>
>