You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/06 21:54:46 UTC

[GitHub] [incubator-superset] etr2460 opened a new pull request #7994: Bump nvd3 charts for tooltip fix

etr2460 opened a new pull request #7994: Bump nvd3 charts for tooltip fix
URL: https://github.com/apache/incubator-superset/pull/7994
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Fixes erroneous removal of tooltips for charts on dashboards. see details at https://github.com/apache-superset/superset-ui-plugins/pull/167
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Use a dashboard with multiple tabs:
   1. hover over a chart on tab 1
   2. switch to tab 2
   3. resize the window, then resize it back to the original size
   4. switch back to tab 1
   5. still see tooltips on the previously hovered chart
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Might be related to #7822
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @kristw @xtinec 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org