You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/20 09:42:42 UTC

[GitHub] [flink] luoyuxia commented on a diff in pull request #21529: [DO NOT MERGE] Testing CI with Hadoop 3 upgrade

luoyuxia commented on code in PR #21529:
URL: https://github.com/apache/flink/pull/21529#discussion_r1053110477


##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1115,33 +1217,8 @@ under the License.
 			<properties>
 				<hive.version>3.1.3</hive.version>
 				<derby.version>10.14.1.0</derby.version>
-				<!-- need a hadoop version that fixes HADOOP-14683 -->
-				<hivemetastore.hadoop.version>2.8.2</hivemetastore.hadoop.version>

Review Comment:
   @MartijnVisser Hi, I found in here, we remove `hivemetastore.hadoop.version`, 
   But before the modification, for hive3 profile, it'll still use hadoop-common 2.8.2 which is same to  `hivemetastore.hadoop.version`. That's how it currently works with Hadoop 3.
    I think we can have two solutions:
   1: revert such change about this part
   2: upgrad the dependency `com.klarna:hiverunner` to 6.0.1 in profile hive3, I have tried in my local and run this test `HiveRunnerITCase#testOrcSchemaEvol`. It turns out it works.
   But I haven't run the whole tests. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org