You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/16 06:36:39 UTC
Review Request 24766: Set ownership of stdout/stderr and container
directory properly.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24766/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/docker.cpp ced0f9247ccb8d1419e464f5c0730b2796ece8e7
Diff: https://reviews.apache.org/r/24766/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24766: Set ownership of stdout/stderr and container
directory properly.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 16, 2014, 4:25 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, lines 801-807
> > <https://reviews.apache.org/r/24766/diff/1/?file=662012#file662012line801>
> >
> > Do you want to chown for fetched stuff as well?
The mesos-fetcher already does that.
> On Aug. 16, 2014, 4:25 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, line 802
> > <https://reviews.apache.org/r/24766/diff/1/?file=662012#file662012line802>
> >
> > You can get rid of the last argument 'true' because the default is 'true'
Oops, thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24766/#review50823
-----------------------------------------------------------
On Aug. 16, 2014, 4:36 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24766/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 4:36 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ced0f9247ccb8d1419e464f5c0730b2796ece8e7
>
> Diff: https://reviews.apache.org/r/24766/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24766: Set ownership of stdout/stderr and container
directory properly.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24766/#review50823
-----------------------------------------------------------
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24766/#comment88685>
Do you want to chown for fetched stuff as well?
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24766/#comment88683>
You can get rid of the last argument 'true' because the default is 'true'
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24766/#comment88684>
Ditto
- Jie Yu
On Aug. 16, 2014, 4:36 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24766/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 4:36 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ced0f9247ccb8d1419e464f5c0730b2796ece8e7
>
> Diff: https://reviews.apache.org/r/24766/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24766: Set ownership of stdout/stderr and container
directory properly.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24766/#review50817
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Aug. 16, 2014, 4:36 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24766/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 4:36 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ced0f9247ccb8d1419e464f5c0730b2796ece8e7
>
> Diff: https://reviews.apache.org/r/24766/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>