You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 05:14:04 UTC

[GitHub] [flink] becketqin commented on pull request #12002: [FLINK-16845][connector/common] Add SourceOperator which runs the Source

becketqin commented on pull request #12002:
URL: https://github.com/apache/flink/pull/12002#issuecomment-625634506


   @StephanEwen Thanks for the review. I only have one concern about the second comment on `withOperatorCoordinator`.
   
   > We need to attach the provider to the JobGraph in the end, but we can keep operator and coordinator together in the StreamTransformation and then attach it to the JobVertex from there.
   
   It depends on whether we want to expose the operator coordinator to users or not. If we want to expose this to the users, by providing a `withOperatorCoordinator` interface, users are able to call `DataStream.transform(operator)` to leverage this mechanism. Also conceptually it seems more intuitive for the coordinator to be associated with the `Operator`, instead of a `StreamTransformation`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org