You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/03/03 04:23:55 UTC
Review Request 31659: Clean up end-to-end tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
-------
Major changes:
- applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
- pulled 'test cases' into individual functions
- simplified (maybe?) setup for tests using SSH
This is being done in preparation for AURORA-1157.
Diffs
-----
src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
Diff: https://reviews.apache.org/r/31659/diff/
Testing
-------
Ran the script.
Thanks,
Bill Farner
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review75045
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On March 3, 2015, 8:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 8:53 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 0f6423521ad2c85032b4825a5b9793dc522a3b70
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 00fa2fb6c272fe01700c4696f92713f11d62230b
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora d987d637da4061cd7946074243daabee4b9a150f
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 072bbb76707e6696815509f21d50b6b5446241b3
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review75049
-----------------------------------------------------------
Ship it!
Master (782e3e7) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 3, 2015, 8:55 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 8:55 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 0f6423521ad2c85032b4825a5b9793dc522a3b70
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 00fa2fb6c272fe01700c4696f92713f11d62230b
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora d987d637da4061cd7946074243daabee4b9a150f
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 072bbb76707e6696815509f21d50b6b5446241b3
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review75090
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On March 3, 2015, 12:55 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:55 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 0f6423521ad2c85032b4825a5b9793dc522a3b70
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 00fa2fb6c272fe01700c4696f92713f11d62230b
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora d987d637da4061cd7946074243daabee4b9a150f
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 072bbb76707e6696815509f21d50b6b5446241b3
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review75048
-----------------------------------------------------------
Ship it!
Just tried this out locally. So much faster, thanks for doing this!
- Joshua Cohen
On March 3, 2015, 8:55 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 8:55 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 0f6423521ad2c85032b4825a5b9793dc522a3b70
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 00fa2fb6c272fe01700c4696f92713f11d62230b
> src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora d987d637da4061cd7946074243daabee4b9a150f
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 072bbb76707e6696815509f21d50b6b5446241b3
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/
-----------------------------------------------------------
(Updated March 3, 2015, 8:55 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
-------
Major changes:
- applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
- pulled 'test cases' into individual functions
- simplified (maybe?) setup for tests using SSH
This is being done in preparation for AURORA-1157.
Diffs (updated)
-----
src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 0f6423521ad2c85032b4825a5b9793dc522a3b70
src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 00fa2fb6c272fe01700c4696f92713f11d62230b
src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora d987d637da4061cd7946074243daabee4b9a150f
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 072bbb76707e6696815509f21d50b6b5446241b3
src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
Diff: https://reviews.apache.org/r/31659/diff/
Testing
-------
Ran the script.
Thanks,
Bill Farner
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/
-----------------------------------------------------------
(Updated March 3, 2015, 8:53 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
-------
Major changes:
- applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
- pulled 'test cases' into individual functions
- simplified (maybe?) setup for tests using SSH
This is being done in preparation for AURORA-1157.
Diffs (updated)
-----
src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 0f6423521ad2c85032b4825a5b9793dc522a3b70
src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 00fa2fb6c272fe01700c4696f92713f11d62230b
src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora d987d637da4061cd7946074243daabee4b9a150f
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 072bbb76707e6696815509f21d50b6b5446241b3
src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
Diff: https://reviews.apache.org/r/31659/diff/
Testing
-------
Ran the script.
Thanks,
Bill Farner
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
> On March 3, 2015, 3:38 a.m., Aurora ReviewBot wrote:
> > Master (4cca6a6) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.update ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.version ..... SUCCESS
> > src.test.python.apache.aurora.client.config ..... SUCCESS
> > src.test.python.apache.aurora.client.factory ..... SUCCESS
> > src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> > src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
> > src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
> > src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
> > src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
> > src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
> > src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
> > src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
> > src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
> > src.test.python.apache.aurora.common.test_transport ..... SUCCESS
> > src.test.python.apache.aurora.config.test_base ..... SUCCESS
> > src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
> > src.test.python.apache.aurora.config.test_loader ..... SUCCESS
> > src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> > src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> > src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> > src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> > src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
> > src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
> > src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
> > src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
> >
> > FAILURE
> >
> > [31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Known flaky test AURORA-1054.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review74881
-----------------------------------------------------------
On March 3, 2015, 3:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review74881
-----------------------------------------------------------
Master (4cca6a6) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 3, 2015, 3:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
> On March 3, 2015, 6:10 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 130
> > <https://reviews.apache.org/r/31659/diff/1/?file=882656#file882656line130>
> >
> > Not directly related but adding --batch-size=2 would make it even faster.
>
> Bill Farner wrote:
> This crossed my mind as well. I've gone ahead and used an update configuration to express this instead.
Brain was disengaged - you were referring to restart, which is unrelated to the update config. I have added batching to the restart command as well.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review74994
-----------------------------------------------------------
On March 3, 2015, 3:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
> On March 3, 2015, 6:10 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 130
> > <https://reviews.apache.org/r/31659/diff/1/?file=882656#file882656line130>
> >
> > Not directly related but adding --batch-size=2 would make it even faster.
This crossed my mind as well. I've gone ahead and used an update configuration to express this instead.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review74994
-----------------------------------------------------------
On March 3, 2015, 3:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review74994
-----------------------------------------------------------
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
<https://reviews.apache.org/r/31659/#comment121886>
Not directly related but adding --batch-size=2 would make it even faster.
- Maxim Khutornenko
On March 3, 2015, 3:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
> On March 3, 2015, 5:23 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 64
> > <https://reviews.apache.org/r/31659/diff/1/?file=882656#file882656line64>
> >
> > Is this statement still accurate now that ssh is dropped from the command?
It is not! Thanks, removed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review74983
-----------------------------------------------------------
On March 3, 2015, 3:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31659: Clean up end-to-end tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review74983
-----------------------------------------------------------
Ship it!
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
<https://reviews.apache.org/r/31659/#comment121857>
Is this statement still accurate now that ssh is dropped from the command?
- Maxim Khutornenko
On March 3, 2015, 3:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
>
> This is being done in preparation for AURORA-1157.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631
> src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7
>
> Diff: https://reviews.apache.org/r/31659/diff/
>
>
> Testing
> -------
>
> Ran the script.
>
>
> Thanks,
>
> Bill Farner
>
>