You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/03 19:13:36 UTC
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5591
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Also clarify commentary for that condition.
Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
---
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
2 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/5591/1
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Add audience="hidden" to DITAVal.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Anonymous Coward #250, Ambreen Kazi,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5591
to look at the new patch set (#2).
Change subject: Add audience="hidden" to DITAVal.
......................................................................
Add audience="hidden" to DITAVal.
That's an alias for audience="Cloudera",
which will be removed in a subsequent CR.
This 2nd patch set is just for practice amending the
commit message without touching any files.
Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
---
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
2 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/5591/2
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5591/1//COMMIT_MSG
Commit Message:
PS1, Line 7: Remove audience="Cloudera" from DITAVal
I tried to amend the commit message when squashing but must have done it wrong. I didn't actually remove audience="Cloudera" yet because that would have caused a build error. I plan to get rid of audience="Cloudera" in 3 stages each with its own gerrit review - add the capability for audience="hidden", global search/replace of audience="Cloudera" -> audience="hidden", and finally remove the possibility of having audience="Cloudera".
http://gerrit.cloudera.org:8080/#/c/5591/1/docs/impala_html.ditaval
File docs/impala_html.ditaval:
Line 21: (obsolete or abandoned), or aspirational (maybe write new topic somewhere down the road).
> long line.
I have an XML formatter tool that will apply some line length constraints, but because that will cause such a large-scale diff across so many files I prefer to address line length globally in a later gerrit review.
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5591/1/docs/impala_html.ditaval
File docs/impala_html.ditaval:
PS1, Line 25: <prop att="audience" val="Cloudera" action="exclude"/>
Hey the commit message said you (I) would remove audience="Cloudera".
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Patch Set 1:
(1 comment)
This is the sort of cleanup work that I propose being allowed to +2 myself.
http://gerrit.cloudera.org:8080/#/c/5591/1/docs/impala_html.ditaval
File docs/impala_html.ditaval:
PS1, Line 25: <prop att="audience" val="Cloudera" action="exclude"/>
> Hey the commit message said you (I) would remove audience="Cloudera".
Yeah, I edited the commit message to clarify but somehow the old message came through when it was pushed. I'm leaving audience="Cloudera" in place so that everything continues to build smoothly until after the big search/replace of audience="Cloudera" -> audience="hidden". After that's complete I'll do a very small update to remove audience="Cloudera" from the 2 .ditaval files.
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward #250 has posted comments on this change.
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add audience="hidden" to DITAVal.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has submitted this change and it was merged.
Change subject: Add audience="hidden" to DITAVal.
......................................................................
Add audience="hidden" to DITAVal.
That's an alias for audience="Cloudera",
which will be removed in a subsequent CR.
This 2nd patch set is just for practice amending the
commit message without touching any files.
Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Reviewed-on: http://gerrit.cloudera.org:8080/5591
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: John Russell <jr...@cloudera.com>
---
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
2 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
John Russell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Add audience="hidden" to DITAVal.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Add audience="hidden" to DITAVal.
......................................................................
Patch Set 2: Code-Review+2 Verified+1
Trivial change by itself, but it's the foundation for some other CRs.
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Patch Set 1:
(2 comments)
> (1 comment)
>
> This is the sort of cleanup work that I propose being allowed to +2
> myself.
I think that's a good topic for a community discussion on dev@. What do you think?
http://gerrit.cloudera.org:8080/#/c/5591/1/docs/impala_html.ditaval
File docs/impala_html.ditaval:
Line 21: (obsolete or abandoned), or aspirational (maybe write new topic somewhere down the road).
long line.
http://gerrit.cloudera.org:8080/#/c/5591/1/docs/impala_pdf.ditaval
File docs/impala_pdf.ditaval:
Line 21: (obsolete or abandoned), or aspirational (maybe write new topic somewhere down the road).
long line
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Patch Set 1:
> (1 comment)
Step 2 should be git rebase -i HEAD~2
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5591/1//COMMIT_MSG
Commit Message:
PS1, Line 7: Remove audience="Cloudera" from DITAVal
> I tried to amend the commit message when squashing but must have done it wr
The steps I use for squashing are:
1. Make the second commit.
2. git rebase -i HEAD~1
3. Mark the first commit reword and the second commit fixup
4. Change the commit message (leaving Change-Id alone)
5. git push to gerrit.
--
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes