You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Alexey Panchenko (JIRA)" <ji...@apache.org> on 2006/09/07 10:11:25 UTC

[jira] Updated: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

     [ http://issues.apache.org/jira/browse/VELOCITY-453?page=all ]

Alexey Panchenko updated VELOCITY-453:
--------------------------------------

    Attachment: IntrospectionCacheDataTest-no-copyright.java 

Sorry, the header was autogenerated by Eclipse and I did not notice it.

> [PATCH] Fix IntrospectionCacheData caching
> ------------------------------------------
>
>                 Key: VELOCITY-453
>                 URL: http://issues.apache.org/jira/browse/VELOCITY-453
>             Project: Velocity
>          Issue Type: Bug
>          Components: Source
>    Affects Versions: 1.5
>            Reporter: Alexey Panchenko
>         Assigned To: Will Glass-Husain
>             Fix For: 1.5
>
>         Attachments: ASTMethod_IntrospectionCacheData_cache, ASTMethod_IntrospectionCacheData_cache-v2-retry.patch, ASTMethod_IntrospectionCacheData_cache-v2.patch, IntrospectionCacheDataTest-no-copyright.java, IntrospectionCacheDataTest-no-copyright.java, IntrospectionCacheDataTest.java
>
>
> The old code used Class[].hashCode() in MethodCacheKey.hashCode() implementation.
> hashCode() is not overriden for arrays so it returns different value for each array instance.
> The attached is the correct implementation and a test case to prove the caching actually works.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org


Re[2]: [jira] Updated: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData

Posted by Alexey Panchenko <al...@olmisoft.com>.
Henning P. Schmiedehausen wrote:

>>Alexey Panchenko updated VELOCITY-453:
>>--------------------------------------

> please note that there are a number of attachments that "don't show
> the feather". Please understand that for legal reasons, we can't apply
> any patches where the "Grant license to ASF for inclusion in ASF works
> (as per the Apache Software License В§5) " on the Attach file page
> hasn't been checked. Sorry 'bout that, legal stuff sucks but
> nevertheless, these are the rules.

I have tried both options but it doesn't work - the files could not be
downloaded back :(

If the file could not be downloaded back - it really does not matter
whether it was checked or not :-)

-- 
Best regards,
 Alexey                            mailto:alex+news@olmisoft.com

Re: [jira] Updated: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData

Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
"Alexey Panchenko (JIRA)" <ji...@apache.org> writes:

>     [ http://issues.apache.org/jira/browse/VELOCITY-453?page=all ]

>Alexey Panchenko updated VELOCITY-453:
>--------------------------------------

Alexey, 

please note that there are a number of attachments that "don't show
the feather". Please understand that for legal reasons, we can't apply
any patches where the "Grant license to ASF for inclusion in ASF works
(as per the Apache Software License §5) " on the Attach file page
hasn't been checked. Sorry 'bout that, legal stuff sucks but
nevertheless, these are the rules.

	Best regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

Social behaviour: Bavarians can be extremely egalitarian and folksy.
                                    -- http://en.wikipedia.org/wiki/Bavaria
Most Franconians do not like to be called Bavarians.
                                    -- http://en.wikipedia.org/wiki/Franconia

---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org