You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by "rjuare8 (via GitHub)" <gi...@apache.org> on 2025/10/03 04:44:40 UTC

[PR] fixed undeterministic RollingAppenderDirectCronTest [logging-log4j2]

rjuare8 opened a new pull request, #3946:
URL: https://github.com/apache/logging-log4j2/pull/3946

   **Stabilize `RollingAppenderDirectCronTest` by waiting for rolled file content and relaxing rollover timeout**  
   Addresses #3046.
   
   > [!IMPORTANT]  
   > Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise.
   
   This PR hardens `RollingAppenderDirectCronTest` against timing races observed with cron-based rollovers. In practice, `rolloverComplete(...)` can fire before the first write to the newly rolled file has reached disk, causing the test to intermittently assert on an empty file. Under scheduler jitter, the test could also time out while waiting for a rollover.
   
   ### What changed (test-only)
   
   - In `rolloverComplete(...)`, wait briefly until the rolled file exists **and** has non-zero length before asserting its contents:
     ```java
     waitAtMost(2, TimeUnit.SECONDS).until(() -> Files.exists(path) && Files.size(path) > 0);
   
   **Why**
   - With CronTriggeringPolicy, the rollover completion callback may run before any event for the new time window is flushed to disk. The test previously asserted isNotEmpty() immediately and could race with IO, leading to flakiness (see #3046).
   
   ## Checklist
   
   Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
   
   ### ✅ Required checks
   
   - ✅ **License**: I confirm that my changes are submitted under the [Apache License, Version 2.0](https://apache.org/licenses/LICENSE-2.0).
   - ✅ **Commit signatures**: All commits are signed and verifiable. (See [GitHub Docs on Commit Signature Verification](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)).
   - ✅ **Code formatting**: The code is formatted according to the project’s style guide.
     <details>
       <summary>How to check and fix formatting</summary>
   
       - To **check** formatting: `./mvnw spotless:check`
       - To **fix** formatting: `./mvnw spotless:apply`
   
       See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
     </details>
   - ✅ **Build & Test**: I verified that the project builds and all unit tests pass.
     <details>
       <summary>How to build the project</summary>
   
       Run: `./mvnw verify`
   
       See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
     </details>
   
   ### 🧪 Tests (select one)
   
   - [ ] I have added or updated tests to cover my changes.
   - ✅ No additional tests are needed for this change.
   
   ### 📝 Changelog (select one)
   
   - [ ] I added a changelog entry in `src/changelog/.2.x.x`. (See [Changelog Entry File Guide](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file)).
   - ✅ This is a trivial change and does not require a changelog entry.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org