You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/29 20:04:03 UTC

[GitHub] [superset] lyndsiWilliams commented on a change in pull request #14881: feat: Database Connection UI

lyndsiWilliams commented on a change in pull request #14881:
URL: https://github.com/apache/superset/pull/14881#discussion_r660925797



##########
File path: superset-frontend/cypress-base/cypress/integration/database/modal.test.ts
##########
@@ -17,75 +17,54 @@
  * under the License.
  */
 import { DATABASE_LIST } from './helper';
-
+// TODO: Add new tests with the modal

Review comment:
       I like that pattern! Fixed in [`this commit`](https://github.com/apache/superset/pull/15463/commits/83e222232aa41a7b4096b815ecff51cf2e0b8ad2).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org