You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/12 07:50:55 UTC
[GitHub] [iotdb] HTHou commented on a change in pull request #2445: Remove versionInfo in Tsfile and get rid of versions in memtable
HTHou commented on a change in pull request #2445:
URL: https://github.com/apache/iotdb/pull/2445#discussion_r555481211
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -97,8 +96,8 @@ public void syncFlushMemTable()
}
noMoreEncodingTask = true;
logger.debug(
- "Storage group {} memtable {}, flushing into disk: data sort time cost {} ms.",
- storageGroup, memTable.getVersion(), sortTime);
+ "Storage group {} memtable flushing into disk: data sort time cost {} ms.",
Review comment:
Same as above.
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -180,8 +177,8 @@ public void run() {
try {
TimeUnit.MILLISECONDS.sleep(10);
} catch (@SuppressWarnings("squid:S2142") InterruptedException e) {
- logger.error("Storage group {} memtable {}, encoding task is interrupted.",
- storageGroup, memTable.getVersion(), e);
+ logger.error("Storage group {} memtable encoding task is interrupted.",
Review comment:
Same as above.
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -241,15 +237,14 @@ public void run() {
this.writer.endChunkGroup();
}
} catch (IOException e) {
- logger.error("Storage group {} memtable {}, io task meets error.", storageGroup,
- memTable.getVersion(), e);
+ logger.error("Storage group {} memtable io task meets error.", storageGroup, e);
Review comment:
Same
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -67,8 +67,7 @@ public MemTableFlushTask(IMemTable memTable, RestorableTsFileIOWriter writer, St
this.storageGroup = storageGroup;
this.encodingTaskFuture = subTaskPoolManager.submit(encodingTask);
this.ioTaskFuture = subTaskPoolManager.submit(ioTask);
- logger.debug("flush task of Storage group {} memtable {} is created ",
- storageGroup, memTable.getVersion());
+ logger.debug("flush task of Storage group {} memtable is created ", storageGroup);
Review comment:
What about add a file name?
```suggestion
logger.debug("flush task of Storage group {} memtable of file {} is created ", storageGroup, writer.getFile().getName());
```
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -199,17 +196,17 @@ public void run() {
}
}
noMoreIOTask = true;
- logger.debug("Storage group {}, flushing memtable {} into disk: Encoding data cost "
+ logger.debug("Storage group {}, flushing memtable into disk: Encoding data cost "
+ "{} ms.",
- storageGroup, memTable.getVersion(), memSerializeTime);
+ storageGroup, memSerializeTime);
}
};
@SuppressWarnings("squid:S135")
private Runnable ioTask = () -> {
long ioTime = 0;
boolean returnWhenNoTask = false;
- logger.debug("Storage group {} memtable {}, start io.", storageGroup, memTable.getVersion());
+ logger.debug("Storage group {} memtable start io.", storageGroup);
Review comment:
Same
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -241,15 +237,14 @@ public void run() {
this.writer.endChunkGroup();
}
} catch (IOException e) {
- logger.error("Storage group {} memtable {}, io task meets error.", storageGroup,
- memTable.getVersion(), e);
+ logger.error("Storage group {} memtable io task meets error.", storageGroup, e);
throw new FlushRunTimeException(e);
}
ioTime += System.currentTimeMillis() - starTime;
}
}
- logger.debug("flushing a memtable {} in storage group {}, io cost {}ms", memTable.getVersion(),
- storageGroup, ioTime);
+ logger.debug("flushing a memtable in storage group {}, io cost {}ms",
Review comment:
Same
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -199,17 +196,17 @@ public void run() {
}
}
noMoreIOTask = true;
- logger.debug("Storage group {}, flushing memtable {} into disk: Encoding data cost "
+ logger.debug("Storage group {}, flushing memtable into disk: Encoding data cost "
Review comment:
Same
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -166,8 +164,7 @@ private void writeOneSeries(TVList tvPairs, IChunkWriter seriesWriterImpl,
public void run() {
long memSerializeTime = 0;
boolean noMoreMessages = false;
- logger.debug("Storage group {} memtable {}, starts to encoding data.", storageGroup,
- memTable.getVersion());
+ logger.debug("Storage group {} memtable starts to encoding data.", storageGroup);
Review comment:
Same as above.
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -222,8 +219,7 @@ public void run() {
try {
TimeUnit.MILLISECONDS.sleep(10);
} catch (@SuppressWarnings("squid:S2142") InterruptedException e) {
- logger.error("Storage group {} memtable {}, io task is interrupted.", storageGroup
- , memTable.getVersion());
+ logger.error("Storage group {} memtable io task is interrupted.", storageGroup);
Review comment:
Same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org