You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "niliushall (via GitHub)" <gi...@apache.org> on 2024/01/01 10:12:15 UTC

[PR] [hotfix] [docs, RestartStrategyOptions]: update the default of "fixed-d… [flink]

niliushall opened a new pull request, #24013:
URL: https://github.com/apache/flink/pull/24013

   
   ## What is the purpose of the change
   
   The default value of `restart-strategy.fixed-delay.attempts` in `RestartStrategyOptions.java` is 1， but the value of the parameter in the description of `restart-strategy.type` and the content of `task_failure_recovery.md` is `Integer.MAX_VALUE`. To ensure the consistency of the description and code, the above content should be modified.
   
   The versions with the above problems are: 1.14 -> latest version
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive):no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] [docs, RestartStrategyOptions]: update the default value of "restart-strategy.fixed-delay.attempts" to 1 in docs [flink]

Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on PR #24013:
URL: https://github.com/apache/flink/pull/24013#issuecomment-1954389992

   Thanks for the PR!
   I suggest creating a jira ticket for this. And it would be better if the description in `org.apache.flink.configuration.RestartStrategyOptions` is also fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] [docs, RestartStrategyOptions]: update the default value of "restart-strategy.fixed-delay.attempts" to 1 in docs [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24013:
URL: https://github.com/apache/flink/pull/24013#issuecomment-1873260605

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "892a6d8944160dd5e871c5ee7e8cbdf96bea0e8c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "892a6d8944160dd5e871c5ee7e8cbdf96bea0e8c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 892a6d8944160dd5e871c5ee7e8cbdf96bea0e8c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] [docs, RestartStrategyOptions]: update the default value of "restart-strategy.fixed-delay.attempts" to 1 in docs [flink]

Posted by "niliushall (via GitHub)" <gi...@apache.org>.
niliushall commented on PR #24013:
URL: https://github.com/apache/flink/pull/24013#issuecomment-1873262601

   @roncohen @hadronzoo @is @rehevkor5 Could you please take a look at this pr in your free time? Thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org