You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by julio cesar sanchez <jc...@gmail.com> on 2018/04/15 21:16:28 UTC
Re: [DISCUSS] [Play Services Version]
Was this totally implemented? Fix version of the issue linked says cordova
7.2.0, which doesn't exist.
Not sure if it wasn't completed or if it's broken, but doesn't seem to work
on cordova 8.0.0
If I add this to my config.xml
<preference name="FCM_VERSION" value="10+" />
and install phonegap-plugin-push, which has that variable, it always use
the variable default version (or the one I specify) and not the one I try
to set from the config.xml
Also, if I change the variable value in the config.xml, it has no effect, I
have to uninstall and reinstall using the new value. Is that expected?
2017-08-18 21:11 GMT+02:00 Steven Gill <st...@gmail.com>:
> The solution I'm working on in that discuss repo would allow users to set
> the versions on config.xml. It isn't tied to play services
>
> Plugin devs would have to modify the framework tags to use a variable
>
> On Aug 18, 2017 12:03 PM, "julio cesar sanchez" <jc...@gmail.com>
> wrote:
>
> > Yes, that one is for forcing Android Support Libraries to use the 25
> > version, but the problem is the same as with Google Play Services,
> plugins
> > using different versions of libraries causing conflict between them.
> >
> > 2017-08-18 19:49 GMT+02:00 Steven Gill <st...@gmail.com>:
> >
> > > On first glance, that plugin does seem to solve a similar problem.
> > >
> > > On Fri, Aug 18, 2017 at 10:45 AM, Jan Piotrowski <piotrowski@gmail.com
> >
> > > wrote:
> > >
> > > > Is this the same problem that (allegedly) can be fixed by using this
> > > > plugin?
> > > > https://github.com/dpa99c/cordova-android-support-gradle-release
> > > >
> > > > 2017-08-18 18:02 GMT+02:00 julio cesar sanchez <
> jcesarmobile@gmail.com
> > >:
> > > > > This problem is not only present on Play Services version, any
> other
> > > > > library or framework, from Android (like support libraries) or any
> > 3rd
> > > > > party.
> > > > > For 3rd party is less common, but for support libraries is very
> > common
> > > to
> > > > > have this kind of problem.
> > > > >
> > > > > I have had another idea that I think should be simpler, but will
> be a
> > > big
> > > > > breaking change.
> > > > >
> > > > > What if we drop support for the framework tag in plugin xml and
> move
> > > the
> > > > > functionality to config.xml?
> > > > >
> > > > > Plugin authors should use config-file tag to add the framework on
> the
> > > > > config.xml, something like
> > > > > <config-file target="config.xml" parent="/*">
> > > > > <framework src="com.android.support:support-v4:24.1.1+" />
> > > > > </config-file>
> > > > >
> > > > >
> > > > > The problem is that any plugin using a framework will need an
> update,
> > > > while
> > > > > the other proposed approach will only need to update conflicting
> > > plugins.
> > > > >
> > > > >
> > > > > And if the config.xml already includes a
> > com.android.support:support-v4
> > > > > then ignore it.
> > > > >
> > > > > El 8 ago. 2017 3:03 p. m., "Audrey So" <au...@adobe.com.invalid>
> > > > escribió:
> > > > >
> > > > >> Hi all!
> > > > >>
> > > > >>
> > > > >> There is a proposal to offer an alternative solution for CB-13145:
> > > > >> https://issues.apache.org/jira/browse/CB-13145.
> > > > >>
> > > > >> Please review the proposal below:
> > > > >>
> > > > >> https://github.com/cordova/cordova-discuss/pull/74/files
> > > > >>
> > > > >>
> > > > >> We would appreciate any feedback, advice, comments, and questions
> > you
> > > > have
> > > > >> on this proposal. Looking forward to hearing any thoughts. Thanks
> so
> > > > much!
> > > > >>
> > > > >>
> > > > >> Audrey
> > > > >>
> > > >
> > > > ------------------------------------------------------------
> ---------
> > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] [Play Services Version]
Posted by Simon MacDonald <si...@gmail.com>.
Yeah, I'm seeing that issue as well. In order to have the change take
affect I need to remove the plugin and add it back in using the CLI to pass
in the variable.
Simon Mac Donald
http://simonmacdonald.com
On Sun, Apr 15, 2018 at 5:16 PM, julio cesar sanchez <jcesarmobile@gmail.com
> wrote:
> Was this totally implemented? Fix version of the issue linked says cordova
> 7.2.0, which doesn't exist.
>
> Not sure if it wasn't completed or if it's broken, but doesn't seem to work
> on cordova 8.0.0
>
> If I add this to my config.xml
> <preference name="FCM_VERSION" value="10+" />
> and install phonegap-plugin-push, which has that variable, it always use
> the variable default version (or the one I specify) and not the one I try
> to set from the config.xml
>
> Also, if I change the variable value in the config.xml, it has no effect, I
> have to uninstall and reinstall using the new value. Is that expected?
>
>
> 2017-08-18 21:11 GMT+02:00 Steven Gill <st...@gmail.com>:
>
> > The solution I'm working on in that discuss repo would allow users to set
> > the versions on config.xml. It isn't tied to play services
> >
> > Plugin devs would have to modify the framework tags to use a variable
> >
> > On Aug 18, 2017 12:03 PM, "julio cesar sanchez" <jc...@gmail.com>
> > wrote:
> >
> > > Yes, that one is for forcing Android Support Libraries to use the 25
> > > version, but the problem is the same as with Google Play Services,
> > plugins
> > > using different versions of libraries causing conflict between them.
> > >
> > > 2017-08-18 19:49 GMT+02:00 Steven Gill <st...@gmail.com>:
> > >
> > > > On first glance, that plugin does seem to solve a similar problem.
> > > >
> > > > On Fri, Aug 18, 2017 at 10:45 AM, Jan Piotrowski <
> piotrowski@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Is this the same problem that (allegedly) can be fixed by using
> this
> > > > > plugin?
> > > > > https://github.com/dpa99c/cordova-android-support-gradle-release
> > > > >
> > > > > 2017-08-18 18:02 GMT+02:00 julio cesar sanchez <
> > jcesarmobile@gmail.com
> > > >:
> > > > > > This problem is not only present on Play Services version, any
> > other
> > > > > > library or framework, from Android (like support libraries) or
> any
> > > 3rd
> > > > > > party.
> > > > > > For 3rd party is less common, but for support libraries is very
> > > common
> > > > to
> > > > > > have this kind of problem.
> > > > > >
> > > > > > I have had another idea that I think should be simpler, but will
> > be a
> > > > big
> > > > > > breaking change.
> > > > > >
> > > > > > What if we drop support for the framework tag in plugin xml and
> > move
> > > > the
> > > > > > functionality to config.xml?
> > > > > >
> > > > > > Plugin authors should use config-file tag to add the framework on
> > the
> > > > > > config.xml, something like
> > > > > > <config-file target="config.xml" parent="/*">
> > > > > > <framework src="com.android.support:support-v4:24.1.1+" />
> > > > > > </config-file>
> > > > > >
> > > > > >
> > > > > > The problem is that any plugin using a framework will need an
> > update,
> > > > > while
> > > > > > the other proposed approach will only need to update conflicting
> > > > plugins.
> > > > > >
> > > > > >
> > > > > > And if the config.xml already includes a
> > > com.android.support:support-v4
> > > > > > then ignore it.
> > > > > >
> > > > > > El 8 ago. 2017 3:03 p. m., "Audrey So" <au...@adobe.com.invalid>
> > > > > escribió:
> > > > > >
> > > > > >> Hi all!
> > > > > >>
> > > > > >>
> > > > > >> There is a proposal to offer an alternative solution for
> CB-13145:
> > > > > >> https://issues.apache.org/jira/browse/CB-13145.
> > > > > >>
> > > > > >> Please review the proposal below:
> > > > > >>
> > > > > >> https://github.com/cordova/cordova-discuss/pull/74/files
> > > > > >>
> > > > > >>
> > > > > >> We would appreciate any feedback, advice, comments, and
> questions
> > > you
> > > > > have
> > > > > >> on this proposal. Looking forward to hearing any thoughts.
> Thanks
> > so
> > > > > much!
> > > > > >>
> > > > > >>
> > > > > >> Audrey
> > > > > >>
> > > > >
> > > > > ------------------------------------------------------------
> > ---------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > > >
> > > > >
> > > >
> > >
> >
>