You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/11/06 09:51:16 UTC
[GitHub] [fineract] vidakovic opened a new pull request, #2727: FINERACT-1795: Improve resilience of command processing service
vidakovic opened a new pull request, #2727:
URL: https://github.com/apache/fineract/pull/2727
Improve the resilience of the command processing service and make retry (and other parameters) configurable (provide reasonable defaults).
The current retry mechanics in place are causing various congestion issues in high traffic deployments. Besides that, we always have to lookup the tenant to retrieve the retry configuration; Spring Boot's application.properties are the proper place for that.
Retries are used currently with 4 service function calls and the code used to implement retries is very repetitive and not very adjustable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
vidakovic commented on PR #2727:
URL: https://github.com/apache/fineract/pull/2727#issuecomment-1304896136
Adjusting the tests took more time than should be necessary... the whole tenant based database setup is impossible to mock for testing... there are just to many factories inside of factories calling static functions in some obscure utility classes.
Found a solution for now and left a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
vidakovic commented on PR #2727:
URL: https://github.com/apache/fineract/pull/2727#issuecomment-1304852539
I've investigated that failure a bit and can't make any sense of it. The server side exception mapping seems to be OK as far as I can tell (investigated all execution paths). Nevertheless, on the integration test we get a HTTP 204 instead of 404. As far as I can see this is not related to my PR (made no changes in the area where things are breaking).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
vidakovic merged PR #2727:
URL: https://github.com/apache/fineract/pull/2727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a diff in pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
vidakovic commented on code in PR #2727:
URL: https://github.com/apache/fineract/pull/2727#discussion_r1015705204
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractPlatformTenantConnection.java:
##########
@@ -171,10 +171,12 @@ public int getMinEvictableIdleTimeMillis() {
return this.minEvictableIdleTimeMillis;
}
+ @Deprecated
Review Comment:
@galovics done... dropped also the columns from the tenant configuration DB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2727:
URL: https://github.com/apache/fineract/pull/2727#discussion_r1015683775
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractPlatformTenantConnection.java:
##########
@@ -171,10 +171,12 @@ public int getMinEvictableIdleTimeMillis() {
return this.minEvictableIdleTimeMillis;
}
+ @Deprecated
Review Comment:
I think let's just cut this out from here and from the DB as well. We'll mention it in the changelog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
vidakovic commented on PR #2727:
URL: https://github.com/apache/fineract/pull/2727#issuecomment-1305716436
Added documentation and more cleanups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a diff in pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
vidakovic commented on code in PR #2727:
URL: https://github.com/apache/fineract/pull/2727#discussion_r1015690800
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractPlatformTenantConnection.java:
##########
@@ -171,10 +171,12 @@ public int getMinEvictableIdleTimeMillis() {
return this.minEvictableIdleTimeMillis;
}
+ @Deprecated
Review Comment:
Very well... on the way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
vidakovic commented on PR #2727:
URL: https://github.com/apache/fineract/pull/2727#issuecomment-1304861821
I think I found it... tricky. Needed to re-throw exception in `logCommand` fallback method; it was swallowing the exceptions and that resulted utlimately in the HTTP 204 code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service
Posted by GitBox <gi...@apache.org>.
vidakovic commented on PR #2727:
URL: https://github.com/apache/fineract/pull/2727#issuecomment-1305199981
Alright... I think that's it. Removed some overly complex error handling for some retry scenarios and fixed a hidden issue in one of the retry fallback functions (missing return type leads to wrong method signature).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org