You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/05 14:27:49 UTC
[GitHub] [spark] cloud-fan opened a new pull request #30264: [SPARK-33360] simplify DS v2 write resolution
cloud-fan opened a new pull request #30264:
URL: https://github.com/apache/spark/pull/30264
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Removing duplicated code in `ResolveOutputRelation`, by adding `V2WriteCommand.withNewQuery`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
code cleanup
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722696513
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722696513
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722696516
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35280/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722616556
**[Test build #130658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130658/testReport)** for PR 30264 at commit [`d6e854c`](https://github.com/apache/spark/commit/d6e854cc414d67571b5a3b1ab23eb22c6b3f7e06).
* This patch passes all tests.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722421797
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130653/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722497907
Could you fix the compilation error?
```
[error] /home/jenkins/workspace/SparkPullRequestBuilder@2/sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala:103:14: class FakeV2WriteCommand needs to be abstract, since:
[error] it has 2 unimplemented members.
[error] /** As seen from class FakeV2WriteCommand, the missing signatures are as follows.
[error] * For convenience, these are usable as stub implementations.
[error] */
[error] def isByName: Boolean = ???
[error] def withNewQuery(newQuery: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan): org.apache.spark.sql.catalyst.plans.logical.V2WriteCommand = ???
[error] case class FakeV2WriteCommand(table: NamedRelation, query: LogicalPlan) extends V2WriteCommand
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722776502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30264:
URL: https://github.com/apache/spark/pull/30264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rdblue commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-723371582
+1
Thanks, @cloud-fan, this looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722566977
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35269/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722677553
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722571780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722566996
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35269/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722416662
**[Test build #130653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130653/testReport)** for PR 30264 at commit [`005eff6`](https://github.com/apache/spark/commit/005eff645a102d64bfe0a9c23066bc39b33b6570).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722668185
**[Test build #130669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130669/testReport)** for PR 30264 at commit [`8579675`](https://github.com/apache/spark/commit/8579675323441c23a7a357e063158d9aa7bd1713).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722421785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722566992
Build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722685550
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35280/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722617887
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722667531
```
Test build #130658 has finished for PR 30264 at commit d6e854c.
This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.
```
Is it false-alarm or can happen? I would expect the tests are even not running once it fails to merge. Anyway, retest would make it clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722571750
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35270/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722566992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722677553
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722775849
**[Test build #130669 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130669/testReport)** for PR 30264 at commit [`8579675`](https://github.com/apache/spark/commit/8579675323441c23a7a357e063158d9aa7bd1713).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30264:
URL: https://github.com/apache/spark/pull/30264#discussion_r518434104
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala
##########
@@ -248,6 +248,68 @@ abstract class DataSourceV2AnalysisBaseSuite extends AnalysisTest {
def byPosition(table: NamedRelation, query: LogicalPlan): LogicalPlan
+ test("SPARK-33136: output resolved on complex types for V2 write commands") {
Review comment:
Is this adding a test case for SPARK-33136 in the PR for SPARK-33360, @cloud-fan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722696497
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35280/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722553104
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35269/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722676685
**[Test build #130659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130659/testReport)** for PR 30264 at commit [`8579675`](https://github.com/apache/spark/commit/8579675323441c23a7a357e063158d9aa7bd1713).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30264:
URL: https://github.com/apache/spark/pull/30264#discussion_r518224305
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala
##########
@@ -100,86 +100,6 @@ class DataFrameWriterV2Suite extends QueryTest with SharedSparkSession with Befo
assert(v2.catalog.exists(_ == catalogPlugin))
}
- case class FakeV2WriteCommand(table: NamedRelation, query: LogicalPlan) extends V2WriteCommand
-
- test("SPARK-33136 output resolved on complex types for V2 write commands") {
Review comment:
This test doesn't use `DataFrameWriterV2` at all. I moved it to `DataSourceV2AnalysisBaseSuite`, so that we don't need the `FakeV2WriteCommand`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722419986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722667593
retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722421757
**[Test build #130653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130653/testReport)** for PR 30264 at commit [`005eff6`](https://github.com/apache/spark/commit/005eff645a102d64bfe0a9c23066bc39b33b6570).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722617887
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722571791
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35270/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722776502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30264:
URL: https://github.com/apache/spark/pull/30264#discussion_r518435128
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala
##########
@@ -248,6 +248,68 @@ abstract class DataSourceV2AnalysisBaseSuite extends AnalysisTest {
def byPosition(table: NamedRelation, query: LogicalPlan): LogicalPlan
+ test("SPARK-33136: output resolved on complex types for V2 write commands") {
Review comment:
Isn't it natural to make this as a follow-up of SPARK-33136 or separate `TEST` PR instead of having in this PR, `Simplify DS v2 write resolution`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722412476
cc @rdblue @HeartSaVioR @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722523372
**[Test build #130658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130658/testReport)** for PR 30264 at commit [`d6e854c`](https://github.com/apache/spark/commit/d6e854cc414d67571b5a3b1ab23eb22c6b3f7e06).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722571780
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722527733
**[Test build #130659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130659/testReport)** for PR 30264 at commit [`8579675`](https://github.com/apache/spark/commit/8579675323441c23a7a357e063158d9aa7bd1713).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722419973
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722523372
**[Test build #130658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130658/testReport)** for PR 30264 at commit [`d6e854c`](https://github.com/apache/spark/commit/d6e854cc414d67571b5a3b1ab23eb22c6b3f7e06).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30264:
URL: https://github.com/apache/spark/pull/30264#discussion_r518435128
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala
##########
@@ -248,6 +248,68 @@ abstract class DataSourceV2AnalysisBaseSuite extends AnalysisTest {
def byPosition(table: NamedRelation, query: LogicalPlan): LogicalPlan
+ test("SPARK-33136: output resolved on complex types for V2 write commands") {
Review comment:
Isn't it natural to make this as a follow-up or separate PR instead of having in this PR, `Simplify DS v2 write resolution`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722416662
**[Test build #130653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130653/testReport)** for PR 30264 at commit [`005eff6`](https://github.com/apache/spark/commit/005eff645a102d64bfe0a9c23066bc39b33b6570).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30264: [SPARK-33360] simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722419973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722552468
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35270/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722668185
**[Test build #130669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130669/testReport)** for PR 30264 at commit [`8579675`](https://github.com/apache/spark/commit/8579675323441c23a7a357e063158d9aa7bd1713).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722527733
**[Test build #130659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130659/testReport)** for PR 30264 at commit [`8579675`](https://github.com/apache/spark/commit/8579675323441c23a7a357e063158d9aa7bd1713).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org