You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/06 08:01:37 UTC
[GitHub] [incubator-dolphinscheduler] yangyichao-mango opened a new pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error
yangyichao-mango opened a new pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911
## What is the purpose of the pull request
*Fix the mysql version and datetime sql syntax limited error for 5.5x - 5.64.*
## Brief change log
- *Remove the CURRENT_TIMESTAMP in sql file.*
- *Change the sql datetime(0) syntax to common syntax datetime, because mysql5.5x does not support the datetime(0) syntax, and datetime syntax is be in common use in mysql5.x and mysql8.x.*
- *There is no need to set datetime in java code, because the default time was set up before.*
## Verify this pull request
This pull request is code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango removed a comment on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error
Posted by GitBox <gi...@apache.org>.
yangyichao-mango removed a comment on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-640012833
> good idea.
>
> if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine
Thx for your review.
The java code has done the setter operation for create_time and update_time in previous version.
I've checked the java code and deployed the app to test this part.
When I do insert operation, it will generate create_time and update_time in db correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-644136125
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2911&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2911&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2911&metric=duplicated_lines_density&view=list) No Duplication information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango removed a comment on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error
Posted by GitBox <gi...@apache.org>.
yangyichao-mango removed a comment on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-640018981
> good idea.
>
> if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine
Thx for your review.
Do I need to check all the released version and fix that issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-644200586
good job, please contact me(lidongdai@apache.org) or wechat(510570367) , when added, please tell me your github id, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-640012833
> good idea.
>
> if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine
Thx for your review.
The java code has done the setter operation for create_time and update_time in previous version.
I've checked the java code and deployed the app to test this part.
When I do insert operation, it will generate create_time and update_time in db correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-644134614
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911?src=pr&el=h1) Report
> Merging [#2911](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/24c7f764f60c97160f13e437b10858e4d3749795&el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2911 +/- ##
============================================
- Coverage 39.57% 39.39% -0.18%
+ Complexity 2711 2701 -10
============================================
Files 435 435
Lines 20116 20116
Branches 2453 2453
============================================
- Hits 7960 7925 -35
- Misses 11400 11438 +38
+ Partials 756 753 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dolphinscheduler/common/enums/SqoopJobType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Nxb29wSm9iVHlwZS5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../server/worker/processor/TaskExecuteProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVQcm9jZXNzb3IuamF2YQ==) | `10.16% <0.00%> (-27.12%)` | `1.00% <0.00%> (-2.00%)` | |
| [...nscheduler/server/entity/TaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9UYXNrRXhlY3V0aW9uQ29udGV4dC5qYXZh) | `89.10% <0.00%> (-9.91%)` | `61.00% <0.00%> (-5.00%)` | |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `74.00% <0.00%> (-2.00%)` | `25.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911?src=pr&el=footer). Last update [24c7f76...39528e9](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2911?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-640018981
> good idea.
>
> if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine
Thx for your review.
Do I need to check all the released version and fix that issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-640011895
good idea.
if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-640041453
> good idea.
>
> if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine
Thx for your review.
I've checked all the active dev branches and fixed [2127](https://github.com/apache/incubator-dolphinscheduler/issues/2127) in those dev branches
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #2911: [Feature-2127][sql-schema] Fix the mysql version limited error
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #2911:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2911#issuecomment-640041453
> good idea.
>
> if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine
Thx for your review.
I've checked all the active dev branch and fixed [2127](https://github.com/apache/incubator-dolphinscheduler/issues/2127) in those dev branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org