NMS 1.8.0 SessionExtensions not defined on .NET Framework

[W B D <wb...@users.sourceforge.net>]

I have tried updating the Apache.ActiveMQ.NMS Nuget package to 1.8.0 in my
project, and am getting build errors indicating that the GetDestination
method is not available on ISession.

This method is defined in the SessionExtensions class, but it is
conditionally compiled only if the symbol MONO or NET_3_5 is defined.

I assume that this was defined previously, but is now inadvertently omitted
as part of the restructuring that was done for 1.8. Probably, the extension
methods could be defined for any supported version of .NET at this point,
as .NET < 3.5 is no longer supported by the project.

The extension method simply delegates to SessionUtil.GetDestination, which
is exposed to public as well, so for my immediate need I just called that
directly.
However, I assume this should not have been necessary and that the
extension methods should still be provided as before, rather than have a
breaking change.

Re: NMS 1.8.0 SessionExtensions not defined on .NET Framework

[W B D <wb...@users.sourceforge.net>]

Created as AMQNET-631 https://issues.apache.org/jira/browse/AMQNET-631 -
thanks!


On Thu, Nov 28, 2019 at 12:16 PM Krzysztof <h4...@gmail.com> wrote:

> Hi,
>
> We must have missed that during the work on .net standard migration. Feel
> free to submit the issue
> https://issues.apache.org/jira/projects/AMQNET/summary and we can expose
> this api back again.
>
> Krzysztof Porebski
>
> On Thu, Nov 28, 2019 at 9:02 PM W B D <wb...@users.sourceforge.net> wrote:
>
> > I have tried updating the Apache.ActiveMQ.NMS Nuget package to 1.8.0 in
> my
> > project, and am getting build errors indicating that the GetDestination
> > method is not available on ISession.
> >
> > This method is defined in the SessionExtensions class, but it is
> > conditionally compiled only if the symbol MONO or NET_3_5 is defined.
> >
> > I assume that this was defined previously, but is now inadvertently
> omitted
> > as part of the restructuring that was done for 1.8. Probably, the
> extension
> > methods could be defined for any supported version of .NET at this point,
> > as .NET < 3.5 is no longer supported by the project.
> >
> > The extension method simply delegates to SessionUtil.GetDestination,
> which
> > is exposed to public as well, so for my immediate need I just called that
> > directly.
> > However, I assume this should not have been necessary and that the
> > extension methods should still be provided as before, rather than have a
> > breaking change.
> >
>

Re: NMS 1.8.0 SessionExtensions not defined on .NET Framework

[Krzysztof <h4...@gmail.com>]

Hi,

We must have missed that during the work on .net standard migration. Feel
free to submit the issue
https://issues.apache.org/jira/projects/AMQNET/summary and we can expose
this api back again.

Krzysztof Porebski

On Thu, Nov 28, 2019 at 9:02 PM W B D <wb...@users.sourceforge.net> wrote:

> I have tried updating the Apache.ActiveMQ.NMS Nuget package to 1.8.0 in my
> project, and am getting build errors indicating that the GetDestination
> method is not available on ISession.
>
> This method is defined in the SessionExtensions class, but it is
> conditionally compiled only if the symbol MONO or NET_3_5 is defined.
>
> I assume that this was defined previously, but is now inadvertently omitted
> as part of the restructuring that was done for 1.8. Probably, the extension
> methods could be defined for any supported version of .NET at this point,
> as .NET < 3.5 is no longer supported by the project.
>
> The extension method simply delegates to SessionUtil.GetDestination, which
> is exposed to public as well, so for my immediate need I just called that
> directly.
> However, I assume this should not have been necessary and that the
> extension methods should still be provided as before, rather than have a
> breaking change.
>