[jira] [Commented] (GROOVY-8557) Verify that CliBuilder-based applications work correctly with picocli version of CliBuilder

["Remko Popma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-8557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460283#comment-16460283 ] 

Remko Popma commented on GROOVY-8557:
-------------------------------------

I tried changing {{gradle/assemble.gradle}} and managed to get the picocli classes moved to the groovyjarjarpicocli package, but for some reason the groovy-3.0.0-SNAPSHOT.jar does not contain any of the CliBuilder classes. Not sure what I'm doing wrong. Here are my changes to assemble.gradle:

{noformat}
Index: gradle/assemble.gradle
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- gradle/assemble.gradle	(revision 10a7a3c6dc8a4974a4ed7fd1b35adabcd079eaa9)
+++ gradle/assemble.gradle	(date 1525211325893)
@@ -199,7 +199,7 @@
                             return component.module in [
                                     'antlr', 'antlr-runtime', 'antlr4', 'antlr4-runtime', 'antlr4-annotations',
                                     'asm', 'asm-commons', 'asm-tree', 'asm-util',
-                                    'commons-cli']
+                                    'commons-cli', 'picocli']
                         }
                         return false
                     }
@@ -209,16 +209,21 @@
             }
             jarjarToolClasspath = rootProject.configurations.tools
             untouchedFiles = [
-                    'org/codehaus/groovy/cli/GroovyPosixParser*.class',
+                    'groovy/cli/commons/CliBuilder*.class',
+                    'groovy/cli/commons/OptionAccessor*.class',
+                    'groovy/cli/picocli/CliBuilder*.class',
+                    'groovy/cli/picocli/OptionAccessor*.class',
                     'groovy/util/CliBuilder*.class',
                     'groovy/util/OptionAccessor*.class',
+                    'org/codehaus/groovy/cli/GroovyPosixParser*.class',
                     'org/codehaus/groovy/tools/shell/util/HelpFormatter*.class'
             ]
             patterns = [
                     'antlr.**'                 : 'groovyjarjarantlr.@1', // antlr2
                     'org.antlr.**'             : 'groovyjarjarantlr4.@1', // antlr4
                     'org.objectweb.**'         : 'groovyjarjarasm.@1',
-                    'org.apache.commons.cli.**': 'groovyjarjarcommonscli.@1'
+                    'org.apache.commons.cli.**': 'groovyjarjarcommonscli.@1',
+                    'picocli.**'               : 'groovyjarjarpicocli.@1'
             ]
             excludesPerLibrary = [
                     '*': ['META-INF/maven/**', 'META-INF/*', 'META-INF/services/javax.annotation.processing.Processor', 'module-info.class']
{noformat}

> Verify that CliBuilder-based applications work correctly with picocli version of CliBuilder
> -------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-8557
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8557
>             Project: Groovy
>          Issue Type: Task
>          Components: command line processing
>            Reporter: Remko Popma
>            Priority: Major
>
> Follow-up task for GROOVY-8520. The following applications depend on CliBuilder:
> * groovy-console_main/groovy.ui.Console.groovy
> * groovy-docgenerator_main/org.codehaus.groovy.tools.DocGenerator.groovy
> * groovy-groovydoc_main/org.codehaus.groovy.tools.groovydoc.Main.groovy
> * groovy-groovysh_main/org.codehaus.groovy.tools.shell.Main.groovy (uses custom HelpFormatter)
> This task is to verify that the above applications work correctly with the picocli version of CliBuilder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)