You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/16 09:04:43 UTC

[GitHub] [skywalking] JohnNiang opened a new pull request #4248: Fix typo: guideline and code document

JohnNiang opened a new pull request #4248: Fix typo: guideline and code document
URL: https://github.com/apache/skywalking/pull/4248
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   Replace with correct spell.
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JohnNiang commented on issue #4248: Fix typo: guideline and code document

Posted by GitBox <gi...@apache.org>.
JohnNiang commented on issue #4248: Fix typo: guideline and code document
URL: https://github.com/apache/skywalking/pull/4248#issuecomment-575114251
 
 
   > Welcome to be 199th contributor
   
   My pleasure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4248: Fix typo: guideline and code document

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4248: Fix typo: guideline and code document
URL: https://github.com/apache/skywalking/pull/4248
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4248: Fix typo: guideline and code document

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4248: Fix typo: guideline and code document
URL: https://github.com/apache/skywalking/pull/4248#issuecomment-575112331
 
 
   Welcome to be 199th contributor

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4248: Fix typo: guideline and code document

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4248: Fix typo: guideline and code document
URL: https://github.com/apache/skywalking/pull/4248#issuecomment-575111577
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4248?src=pr&el=h1) Report
   > Merging [#4248](https://codecov.io/gh/apache/skywalking/pull/4248?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/867c443fb52ac6ca723425ef11aeb8d3fe4b3cc5?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4248/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4248?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4248   +/-   ##
   =======================================
     Coverage   26.35%   26.35%           
   =======================================
     Files        1179     1179           
     Lines       25805    25805           
     Branches     3749     3749           
   =======================================
     Hits         6800     6800           
     Misses      18402    18402           
     Partials      603      603
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4248?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4248?src=pr&el=footer). Last update [867c443...a9b8e50](https://codecov.io/gh/apache/skywalking/pull/4248?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services