You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by wuchong <gi...@git.apache.org> on 2016/03/03 02:50:48 UTC
[GitHub] flink pull request: [docs] fix javascript exception caused by disq...
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/1756
[docs] fix javascript exception caused by disqus
As we comment `<div id="disqus_thread"></div>` but not the disqus javascript. It will cause a exception like this:
And fix a minor typo in `cluster_execution.md`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1756.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1756
----
commit 713d418b6259ee94abe35edf710c5cabf978e1c2
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2016-03-03T01:43:38Z
[docs] fix javascript exception caused by disqus and fix typos in cluster execution.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] fix javascript exception caused by disq...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1756
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] fix javascript exception caused by disq...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1756#issuecomment-191915950
This looks like a good fix, thanks for contributing!
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] fix javascript exception caused by disq...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1756#issuecomment-192362732
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---