You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2024/04/03 10:37:20 UTC

[PR] [SEDONA-527] Add `pre-commit` hook `check-json`; Lint JSON files [sedona]

jbampton opened a new pull request, #1311:
URL: https://github.com/apache/sedona/pull/1311

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-527. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   ## What changes were proposed in this PR?
   
   Added another hook to our pre-commit framework:
   
   https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-json
   
   ## How was this patch tested?
   
   With the new hook `check-json` added I first ran locally:
   
   `pre-commit run --all-files`
   
   which showed the JSON files that weren't valid JSON.
   
   Then checked some JSON with JSON Lint online.
   
   https://jsonlint.com/
   
   Then fixed the JSON to be valid JSON.
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CI] Add pre-commit hook check-json [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1311:
URL: https://github.com/apache/sedona/pull/1311


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org