You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/29 12:19:10 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request, #23170: Use way of AgentServiceLoader to simplify ShardingSphereServiceLoader
terrymanu opened a new pull request, #23170:
URL: https://github.com/apache/shardingsphere/pull/23170
Fixes #23035.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [X] I have self-reviewed the commit code.
- [X] I have (or in comment I request) added corresponding labels for the pull request.
- [X] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [X] I have made corresponding changes to the documentation.
- [X] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23170: Use way of AgentServiceLoader to simplify ShardingSphereServiceLoader
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23170:
URL: https://github.com/apache/shardingsphere/pull/23170#issuecomment-1367297503
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23170](https://codecov.io/gh/apache/shardingsphere/pull/23170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5bfc713) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a190fd5e3cc352545fbc7f0ec84015627b0ec132?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a190fd5) will **decrease** coverage by `0.10%`.
> The diff coverage is `77.27%`.
```diff
@@ Coverage Diff @@
## master #23170 +/- ##
============================================
- Coverage 49.97% 49.87% -0.11%
- Complexity 2437 2442 +5
============================================
Files 4116 4008 -108
Lines 57630 57329 -301
Branches 9105 9100 -5
============================================
- Hits 28801 28590 -211
+ Misses 26297 26197 -100
- Partials 2532 2542 +10
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ingsphere/dialect/SQLExceptionTransformEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlhbGVjdC1leGNlcHRpb24vY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlhbGVjdC9TUUxFeGNlcHRpb25UcmFuc2Zvcm1FbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...featured/FeaturedDistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUvZmVhdHVyZWQvRmVhdHVyZWREaXN0U1FMU3RhdGVtZW50UGFyc2VyRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...te/AlterDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9BbHRlckRhdGFiYXNlRGlzY292ZXJ5UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `86.95% <0.00%> (ø)` | |
| [...ndler/update/AlterEncryptRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9BbHRlckVuY3J5cHRSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `86.53% <0.00%> (ø)` | |
| [...gine/impl/InsertClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9lbmdpbmUvaW1wbC9JbnNlcnRDbGF1c2VTaGFyZGluZ0NvbmRpdGlvbkVuZ2luZS5qYXZh) | `82.60% <0.00%> (ø)` | |
| [...r/impl/ConditionValueCompareOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9nZW5lcmF0b3IvaW1wbC9Db25kaXRpb25WYWx1ZUNvbXBhcmVPcGVyYXRvckdlbmVyYXRvci5qYXZh) | `79.16% <0.00%> (ø)` | |
| [...r/algorithm/CacheableShardingAlgorithmChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvcGx1Z2luL2NhY2hlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9jYWNoZS9jaGVja2VyL2FsZ29yaXRobS9DYWNoZWFibGVTaGFyZGluZ0FsZ29yaXRobUNoZWNrZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...fra/instance/metadata/InstanceMetaDataFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9pbnN0YW5jZS9tZXRhZGF0YS9JbnN0YW5jZU1ldGFEYXRhRmFjdG9yeS5qYXZh) | `100.00% <ø> (ø)` | |
| [.../database/schema/builder/GenericSchemaBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvYnVpbGRlci9HZW5lcmljU2NoZW1hQnVpbGRlci5qYXZh) | `56.25% <0.00%> (-4.69%)` | :arrow_down: |
| [.../loader/dialect/OpenGaussSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvT3BlbkdhdXNzU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `2.94% <0.00%> (ø)` | |
| ... and [220 more](https://codecov.io/gh/apache/shardingsphere/pull/23170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23170: Use way of AgentServiceLoader to simplify ShardingSphereServiceLoader
Posted by GitBox <gi...@apache.org>.
zhaojinchao95 merged PR #23170:
URL: https://github.com/apache/shardingsphere/pull/23170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org