You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by rf...@apache.org on 2009/02/17 18:48:22 UTC

svn commit: r745170 - /tuscany/branches/sca-java-1.x/modules/contribution/src/main/java/org/apache/tuscany/sca/contribution/processor/DefaultValidatingXMLInputFactory.java

Author: rfeng
Date: Tue Feb 17 17:48:22 2009
New Revision: 745170

URL: http://svn.apache.org/viewvc?rev=745170&view=rev
Log:
Use Logger instead e.printStackTrace

Modified:
    tuscany/branches/sca-java-1.x/modules/contribution/src/main/java/org/apache/tuscany/sca/contribution/processor/DefaultValidatingXMLInputFactory.java

Modified: tuscany/branches/sca-java-1.x/modules/contribution/src/main/java/org/apache/tuscany/sca/contribution/processor/DefaultValidatingXMLInputFactory.java
URL: http://svn.apache.org/viewvc/tuscany/branches/sca-java-1.x/modules/contribution/src/main/java/org/apache/tuscany/sca/contribution/processor/DefaultValidatingXMLInputFactory.java?rev=745170&r1=745169&r2=745170&view=diff
==============================================================================
--- tuscany/branches/sca-java-1.x/modules/contribution/src/main/java/org/apache/tuscany/sca/contribution/processor/DefaultValidatingXMLInputFactory.java (original)
+++ tuscany/branches/sca-java-1.x/modules/contribution/src/main/java/org/apache/tuscany/sca/contribution/processor/DefaultValidatingXMLInputFactory.java Tue Feb 17 17:48:22 2009
@@ -28,6 +28,8 @@
 import java.security.PrivilegedActionException;
 import java.security.PrivilegedExceptionAction;
 import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import javax.xml.XMLConstants;
 import javax.xml.stream.EventFilter;
@@ -58,7 +60,7 @@
  * @version $Rev$ $Date$
  */
 public class DefaultValidatingXMLInputFactory extends ValidatingXMLInputFactory {
-    
+    private static final Logger logger = Logger.getLogger(DefaultValidatingXMLInputFactory.class.getName());
     private XMLInputFactory inputFactory;
     private ValidationSchemaExtensionPoint schemas;
     private Monitor monitor;
@@ -87,9 +89,11 @@
      */
      private void error(String message, Object model, Exception ex) {
     	 if (monitor != null) {
-    		 Problem problem = new ProblemImpl(this.getClass().getName(), "contribution-validation-messages", Severity.ERROR, model, message, ex);
-    	     monitor.problem(problem);
-    	 }        
+            Problem problem =
+                new ProblemImpl(this.getClass().getName(), "contribution-validation-messages", Severity.ERROR, model,
+                                message, ex);
+            monitor.problem(problem);
+        }        
      }
     
     /**
@@ -126,7 +130,7 @@
                         }
                     });
                 } catch (PrivilegedActionException e) {
-                	error("PrivilegedActionException", url, (IOException)e.getException());
+                    error("PrivilegedActionException", url, (IOException)e.getException());
                     throw (IOException)e.getException();
                 }
                 sources[i] = new StreamSource(urlStream, uri);
@@ -149,14 +153,14 @@
 
         } catch (Error e) {
             // FIXME Log this, some old JDKs don't support XMLSchema validation
-            //e.printStackTrace();
+            logger.log(Level.WARNING, "XML Schema validation is not supported: " + e.getMessage());
         } catch (SAXParseException e) {
-        	IllegalStateException ie = new IllegalStateException(e);
-        	error("IllegalStateException", schemas, ie);
+            IllegalStateException ie = new IllegalStateException(e);
+            error("IllegalStateException", schemas, ie);
             throw ie;
         } catch (Exception e) {
             //FIXME Log this, some old JDKs don't support XMLSchema validation
-            e.printStackTrace();
+            logger.log(Level.WARNING, "XML Schema validation is not supported: " + e.getMessage());
         }
     }