You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 14:41:35 UTC

[GitHub] [arrow] joosthooz commented on pull request #14400: ARROW-17991: [Python] [C++] Added compression support to pyarrow.dataset.ipc format.

joosthooz commented on PR #14400:
URL: https://github.com/apache/arrow/pull/14400#issuecomment-1279102712

   Thanks for the comments. Here's the other approach that exposes `ipc::IpcWriteOptions`: https://github.com/apache/arrow/pull/14414
   
   > I agree it's a bit weird + frustrating that the single file writer options diverge from dataset write options — but maybe we should come back to unify that as a follow on?
   
   This was the reason I started with this approach; to try keep those 2 as similar as possible. Because yes I think if we expose `ipc::IpcWriteOptions` to the dataset writer, we probably also want to use it for the normal ipc writer. And that would add more work to this PR that I didn't want.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org