You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-dev@hadoop.apache.org by "lujie (JIRA)" <ji...@apache.org> on 2018/04/15 14:05:00 UTC

[jira] [Created] (YARN-8164) Fix an Potential NPE

lujie created YARN-8164:
---------------------------

             Summary: Fix an Potential NPE 
                 Key: YARN-8164
                 URL: https://issues.apache.org/jira/browse/YARN-8164
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: lujie


We have developed a static analysis tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential NPE. Our analysis shows that some callees may return null in corner case(e.g. node crash , IO exception), some of their callers have  _!=null_ check but some do not have.

Callee FairScheduler#getAppsInQueue can return null
{code:java}
public List<ApplicationAttemptId> getAppsInQueue(String queueName) {
    FSQueue queue = queueMgr.getQueue(queueName);
   if (queue == null) {
      return null;//here
  }
}
{code}
it has 4 callers, three of them have null checker, one dost not have. In this issue we post a patch which can add  !=null  based on existed !=null  check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org