[jira] [Commented] (PIVOT-721) ButtonDataRenderer#setFillIcon has no effect, because its BoxPane doesn't have fill style

["Sandro Martini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465634#comment-13465634 ] 

Sandro Martini commented on PIVOT-721:
--------------------------------------

Hi Roger, Ok for me it's good the same.
Could you only remember to test your solution even with related test classes ?
Tell me if I can help on this, changing them, or maybe adding tests for the new style if you add it ...

Thanks, and good luck :-) .

                
> ButtonDataRenderer#setFillIcon has no effect, because its BoxPane doesn't have fill style
> -----------------------------------------------------------------------------------------
>
>                 Key: PIVOT-721
>                 URL: https://issues.apache.org/jira/browse/PIVOT-721
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 2.0
>            Reporter: Bill van Melle
>            Assignee: Roger Whitcomb
>            Priority: Minor
>             Fix For: 2.0.3
>
>         Attachments: pivot721_imageview_only_for_debug_DO_NOT_COMMIT.patch
>
>
> ButtonDataRenderer has a setFillIcon method, which supposedly should allow the button's image to be scaled to fit the button.  However, it has no effect, because the renderer is a BoxPane with the default fill=false.
> Fix: In the ButtonDataRenderer constructor, add
>     getStyles().put("fill", true);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira