You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2023/04/26 07:21:41 UTC

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #9706: Sort the result of AlignedUpdateLastCacheOperator for LastQueryMergeOperator

JackieTien97 commented on code in PR #9706:
URL: https://github.com/apache/iotdb/pull/9706#discussion_r1177448350


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/OperatorTreeGenerator.java:
##########
@@ -2292,6 +2293,7 @@ public Operator visitLastQueryMerge(LastQueryMergeNode node, LocalExecutionPlanC
         (items.isEmpty() || items.get(0).getOrdering() == Ordering.ASC)
             ? ASC_BINARY_COMPARATOR
             : DESC_BINARY_COMPARATOR;
+    context.setLastQueryComparator(comparator);

Review Comment:
   won't take effect because children have been visited before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org