You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "David Van Couvering (JIRA)" <de...@db.apache.org> on 2006/01/20 18:36:42 UTC
[jira] Created: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
--------------------------------------------------------------------------------
Key: DERBY-846
URL: http://issues.apache.org/jira/browse/DERBY-846
Project: Derby
Type: Sub-task
Reporter: David Van Couvering
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=comments#action_12377472 ]
David Van Couvering commented on DERBY-846:
-------------------------------------------
Hi, Kathey. In those rare cases in the network client where SqlException already has something besides null for SQLState (which only was happening when DRDA had a required specific SQL State), I have not changed those SQL States. They are still consistent with the spec, as are the error codes. The only thing that has changed in some cases are the error messages, as our messages were just too abstruse and cloaked in DRDA-speak.
SQLExceptionFactory40 is responsible for throwing the right subclass of SQLException based on the type of error. It does this by looking at the SQLState. Previously it did not handle SQLStates as defined by DRDA, many of which indicate a connection exception or a warning, both of which have specific SQLException subclasses associated with them. So I modified SQLExceptionFactory40 to handle the DRDA-specified SQLStates. This ensures that the right subclass is thrown and that application code that is looking for a particular subclass gets it.
David
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-846-rev1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=comments#action_12363856 ]
David Van Couvering commented on DERBY-846:
-------------------------------------------
XN401 - XN450
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=all ]
David Van Couvering reassigned DERBY-846:
-----------------------------------------
Assign To: David Van Couvering
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "Andreas Korneliussen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=comments#action_12377584 ]
Andreas Korneliussen commented on DERBY-846:
--------------------------------------------
In my review comments posted on derbydev, I commented on the error message:
ERROR 08004: Connection authorization failure occurred. Reason: userid invalid.
My comments were to change the message due to security policy reason, and to rephrase.
Thank you for including this into the committed patch. However, I think this change additionally required another master file to be updated
(java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/dataSourcePermissions_net.out)
http://www.multinet.no/~solberg/public/Apache/TinderBox_Derby/testlog/SunOS-5.10_i86pc-i386/399165-derbyall_diff.txt
Note: I have reviewed the committed patch , and found no other issues.
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-846-rev1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=comments#action_12377471 ]
Kathey Marsden commented on DERBY-846:
--------------------------------------
Could you elaborate on this item:
- I modified SQLExceptionFactory to handle DRDA-specified SQL States that indicate a feature is not supported, a connection exception, or a transaction rollback.
Were there specific SQLStates or ErrorCodes were changed?
If so, what are the old and new values?
What behaviour changes would users see as the result of this patch?
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-846-rev1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=all ]
David Van Couvering closed DERBY-846:
-------------------------------------
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-846-rev1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=all ]
David Van Couvering updated DERBY-846:
--------------------------------------
Attachment: DERBY-846-rev1.diff
This patch resolves this issue. A couple of things to note:
- In some areas made some significant changes to the message text, as in many cases it was overly verbose and abstruse. Please see if you like the changes I made
- I modified SQLExceptionFactory to handle DRDA-specified SQL States that indicate a feature is not supported, a connection exception, or a transaction rollback. Take a look and see what you think
Please review. derbyall passes and jdbc40 passes.
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-846-rev1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=all ]
David Van Couvering resolved DERBY-846:
---------------------------------------
Resolution: Fixed
Checked in revisions 399078 and 399351 (missing master file)
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-846-rev1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "Mike Matrigali (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=all ]
Mike Matrigali updated DERBY-846:
---------------------------------
Component: Network Client
Description:
Environment:
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-846) Internationalze NetAgent to
NetDatabaseMetadata40 in org.apache.derby.client.net
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-846?page=comments#action_12377594 ]
David Van Couvering commented on DERBY-846:
-------------------------------------------
Thanks, Andreas, I'll fix this.
> Internationalze NetAgent to NetDatabaseMetadata40 in org.apache.derby.client.net
> --------------------------------------------------------------------------------
>
> Key: DERBY-846
> URL: http://issues.apache.org/jira/browse/DERBY-846
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-846-rev1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira