[GitHub] [ignite-extensions] nva commented on a diff in pull request #229: IGNITE-18302 ignite-spring-sessions: IgniteSession serialization drags its parent class.

["nva (via GitHub)" <gi...@apache.org>]

nva commented on code in PR #229:
URL: https://github.com/apache/ignite-extensions/pull/229#discussion_r1319322429


##########
modules/spring-session-ext/src/main/java/org/apache/ignite/spring/sessions/IgniteIndexedSessionRepository.java:
##########
@@ -169,31 +170,32 @@ public void close() {
      * Sets the {@link ApplicationEventPublisher} that is used to publish
      * {@link AbstractSessionEvent session events}. The default is to not publish session
      * events.
-     * @param applicationEventPublisher the {@link ApplicationEventPublisher} that is used
+     * @param applicationEvtPublisher the {@link ApplicationEventPublisher} that is used
      * to publish session events. Cannot be null.
      */
-    public void setApplicationEventPublisher(ApplicationEventPublisher applicationEventPublisher) {
-        Assert.notNull(applicationEventPublisher, "ApplicationEventPublisher cannot be null");
-        this.eventPublisher = applicationEventPublisher;
+    public void setApplicationEventPublisher(ApplicationEventPublisher applicationEvtPublisher) {
+        Assert.notNull(applicationEvtPublisher, "ApplicationEventPublisher cannot be null");
+        evtPublisher = applicationEvtPublisher;
     }
 
     /**
      * Set the maximum inactive interval in seconds between requests before newly created
-     * sessions will be invalidated. A negative time indicates that the session will never
-     * timeout. The default is 1800 (30 minutes).
-     * @param defaultMaxInactiveInterval the maximum inactive interval in seconds
+     * sessions will be invalidated. A negative time indicates that the session will never timeout.
+     * The default is 1800 (30 minutes).
+     * @param dfltMaxInactiveInterval the maximum inactive interval in seconds
      */
-    public void setDefaultMaxInactiveInterval(Integer defaultMaxInactiveInterval) {
-        this.defaultMaxInactiveInterval = defaultMaxInactiveInterval;
+    public void setDefaultMaxInactiveInterval(Integer dfltMaxInactiveInterval) {
+        this.dfltMaxInactiveInterval = dfltMaxInactiveInterval;
     }
 
     /**
      * Set the {@link IndexResolver} to use.
-     * @param indexResolver the index resolver
+     * @param idxResolver the index resolver
      */
-    public void setIndexResolver(IndexResolver<Session> indexResolver) {
-        Assert.notNull(indexResolver, "indexResolver cannot be null");
-        this.indexResolver = indexResolver;
+    public void setIndexResolver(IndexResolver<Session> idxResolver) {
+        Assert.notNull(idxResolver, "indexResolver cannot be null");

Review Comment:
   I suppose it's ok to have a different name for the variable and use the setter name in assert.
   Same logic was used here ExpressionBasedStringQuery#renderQueryIfExpressionOrReturnQuery



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org