[GitHub] rabbah commented on a change in pull request #2205: Add ability to deploy a "hot-standby" controller

[gi...@git.apache.org]

rabbah commented on a change in pull request #2205: Add ability to deploy a "hot-standby" controller
URL: https://github.com/apache/incubator-openwhisk/pull/2205#discussion_r119812290
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
 ##########
 @@ -77,16 +76,14 @@ protected[core] object EntitlementProvider {
  * A trait that implements entitlements to resources. It performs checks for CRUD and Acivation requests.
  * This is where enforcement of activation quotas takes place, in additional to basic authorization.
  */
-protected[core] abstract class EntitlementProvider(config: WhiskConfig, loadBalancer: LoadBalancer)(
+protected[core] abstract class EntitlementProvider(config: WhiskConfig, loadBalancer: LoadBalancer, controllerInstance: Int)(
 
 Review comment:
   Related to my comment above - the leaking of the instance into the entitlement strikes me as wrong. I understand why it's happening but suggests we're not quite done on this front. Redis perhaps will allow us to address the inconsistency. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services