You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2023/01/28 05:16:18 UTC

[kudu-CR] [WIP]KUDU-1945 Update auto incrementing counter during bootstrap

Hello Marton Greber, Alexey Serbin, Kudu Jenkins, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19445

to look at the new patch set (#2).

Change subject: [WIP]KUDU-1945 Update auto incrementing counter during bootstrap
......................................................................

[WIP]KUDU-1945 Update auto incrementing counter during bootstrap

The auto incrementing counter would be reset to zero when the tablet
is being initialized. It is essential to have the correct value of
the counter. There are two cases:

1. WAL segments contain insert operations
In this scenario the WAL segments are replayed and since each insert
operation entry has auto incrementing counter which will be used for
the insert operations present in that entry, as long as we have the
latest insert operation entry in the WAL segments, the auto
incrementing counter is populated correctly during bootstrap.

2. WAL segments do not contain insert operations
In the case, we need to fetch the highest auto incrementing counter
value present in the data which is already flushed and update the
in memory auto incrementing counter appropriately. This patch
accomplishes this task.
Testing has been done manually. Test cases to follow but feedback
would be appreciated on
1. The above understanding in case I am missing something
2. The patch itself
Change-Id: I61b305efd7d5a065a2976327567163956c0c2184
---
M src/kudu/tablet/tablet.cc
1 file changed, 25 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/19445/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61b305efd7d5a065a2976327567163956c0c2184
Gerrit-Change-Number: 19445
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>