You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 09:39:16 UTC

[GitHub] [superset] villebro opened a new issue #12541: Change dataset header floats on top of table entries

villebro opened a new issue #12541:
URL: https://github.com/apache/superset/issues/12541


   ## Screenshot
   
   ![change_dataset](https://user-images.githubusercontent.com/33317356/104708014-d4c4b600-5725-11eb-9b3f-1e77344b75ba.gif)
   
   ## Description
   
   When scrolling the change dataset table, the header floats above the table entries. Regression caused by #12432
   
   ## Design input
   [describe any input/collaboration you'd like from designers, and
   tag accordingly. For design review, add the
   label `design:review`. If this includes a design proposal,
   include the label `design:suggest`]
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro closed issue #12541: Change dataset header floats on top of table entries

Posted by GitBox <gi...@apache.org>.
villebro closed issue #12541:
URL: https://github.com/apache/superset/issues/12541


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #12541: Change dataset header floats on top of table entries

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12541:
URL: https://github.com/apache/superset/issues/12541#issuecomment-760957230


   
   https://user-images.githubusercontent.com/67837651/104735940-17bb6500-56f7-11eb-952d-c4e5670090fa.mov
   
   this behavior is currently not in master and is mentioned in https://github.com/apache/superset/issues/12503 but yea it would have caused regression thus not including #12432 in v1.0. 🤦🏾‍♀️


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #12541: Change dataset header floats on top of table entries

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12541:
URL: https://github.com/apache/superset/issues/12541#issuecomment-760957230


   
   
   https://user-images.githubusercontent.com/67837651/104735940-17bb6500-56f7-11eb-952d-c4e5670090fa.mov
   
   this behavior is currently not in master and is mentioned in https://github.com/apache/superset/issues/12503 but yea it would have caused regression thus not including #12432 in v1.0. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #12541: Change dataset header floats on top of table entries

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #12541:
URL: https://github.com/apache/superset/issues/12541#issuecomment-760979204


   Closing as this recording does not reflect current state of master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12541: Change dataset header floats on top of table entries

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12541:
URL: https://github.com/apache/superset/issues/12541#issuecomment-760957230


   this behavior is currently not in master and is mentioned in https://github.com/apache/superset/issues/12503 but yea it would have caused regression thus not including #12432 in v1.0. 😅


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #12541: Change dataset header floats on top of table entries

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12541:
URL: https://github.com/apache/superset/issues/12541#issuecomment-760957230


   https://user-images.githubusercontent.com/67837651/104735940-17bb6500-56f7-11eb-952d-c4e5670090fa.mov
   
   this behavior is currently not in master and is mentioned in https://github.com/apache/superset/issues/12503 but yea it would have caused regression without changes made in https://github.com/apache/superset/pull/12471 thus not including #12432 in v1.0. 🤦🏾‍♀️


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #12541: Change dataset header floats on top of table entries

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12541:
URL: https://github.com/apache/superset/issues/12541#issuecomment-760957230


   https://user-images.githubusercontent.com/67837651/104735940-17bb6500-56f7-11eb-952d-c4e5670090fa.mov
   
   this behavior is currently not in master and is mentioned in https://github.com/apache/superset/issues/12503 but yea it would have caused regression without changes made in https://github.com/apache/superset/pull/12471 going in, thus not including both in v1.0. 🤦🏾‍♀️


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org