You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Reminiscent (via GitHub)" <gi...@apache.org> on 2023/06/01 09:34:23 UTC
[GitHub] [doris] Reminiscent opened a new pull request, #20334: [feature](optimizer): support user defined variable
Reminiscent opened a new pull request, #20334:
URL: https://github.com/apache/doris/pull/20334
## Proposed changes
Support user-defined variables.
After this PR, we can use `set @a = xx` to define a user variable and use it in the query like `select @a`.
<--Describe your changes.-->
1. Support the grammar for `set user variable` in the parser.
2.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #20334: [feature](optimizer): support user defined variable
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #20334:
URL: https://github.com/apache/doris/pull/20334#discussion_r1217469180
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java:
##########
@@ -75,6 +75,8 @@ public static Literal of(Object value) {
return new FloatLiteral((Float) value);
} else if (value instanceof Double) {
return new DoubleLiteral((Double) value);
+ } else if (value instanceof BigDecimal) {
+ return new DecimalLiteral((BigDecimal) value);
Review Comment:
```suggestion
if (Config.enable_decimal_conversion) {
return new DecimalV3Literal((BigDecimal) value);
} else {
return new DecimalLiteral((BigDecimal) value);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Reminiscent commented on a diff in pull request #20334: [feature](optimizer): support user defined variable
Posted by "Reminiscent (via GitHub)" <gi...@apache.org>.
Reminiscent commented on code in PR #20334:
URL: https://github.com/apache/doris/pull/20334#discussion_r1217813977
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SetUserDefinedVar.java:
##########
@@ -0,0 +1,38 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+
+public class SetUserDefinedVar extends SetVar {
+ public SetUserDefinedVar(String variable, Expr value) {
+ super(SetType.USER, variable, value, SetVarType.SET_USER_DEFINED_VAR);
+ }
+
+ @Override
+ public void analyze(Analyzer analyzer) {
+ Expr expression = getValue();
+ if (expression instanceof NullLiteral) {
+ setResult(NullLiteral.create(ScalarType.NULL));
+ } else if (expression instanceof LiteralExpr) {
+ setResult((LiteralExpr) expression);
Review Comment:
It depends on whether we have a function that can evaluate those expressions and return the constant value directly. I only find the function `ExpressionEvaluator.eval(expression)` maybe can do this. But it requires the `expression` not the `expr`. So do you have any ideas about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20334: [feature](optimizer): support user defined variable
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20334:
URL: https://github.com/apache/doris/pull/20334#issuecomment-1577990760
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20334: [feature](optimizer): support user defined variable
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20334:
URL: https://github.com/apache/doris/pull/20334#issuecomment-1577990653
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20334: [feature](optimizer): support user defined variable
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20334:
URL: https://github.com/apache/doris/pull/20334#issuecomment-1577990765
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Reminiscent commented on pull request #20334: [feature](optimizer): support user defined variable
Posted by "Reminiscent (via GitHub)" <gi...@apache.org>.
Reminiscent commented on PR #20334:
URL: https://github.com/apache/doris/pull/20334#issuecomment-1576474514
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20334: [feature](optimizer): support user defined variable
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20334:
URL: https://github.com/apache/doris/pull/20334#issuecomment-1577990663
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Reminiscent commented on pull request #20334: [feature](optimizer): support user defined variable
Posted by "Reminiscent (via GitHub)" <gi...@apache.org>.
Reminiscent commented on PR #20334:
URL: https://github.com/apache/doris/pull/20334#issuecomment-1571697704
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Reminiscent commented on pull request #20334: [feature](optimizer): support user defined variable
Posted by "Reminiscent (via GitHub)" <gi...@apache.org>.
Reminiscent commented on PR #20334:
URL: https://github.com/apache/doris/pull/20334#issuecomment-1573229173
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #20334: [feature](optimizer): support user defined variable
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #20334:
URL: https://github.com/apache/doris/pull/20334#discussion_r1217460606
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -989,7 +989,8 @@ public TExpr treeToThrift() {
// Hack to ensure BE never sees TYPE_NULL. If an expr makes it this far without
// being cast to a non-NULL type, the type doesn't matter and we can cast it
// arbitrarily.
- Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef);
+ Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef
+ || this instanceof VariableExpr);
Review Comment:
why we could see VariableExpr here?
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SetUserDefinedVar.java:
##########
@@ -0,0 +1,38 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+
+public class SetUserDefinedVar extends SetVar {
+ public SetUserDefinedVar(String variable, Expr value) {
+ super(SetType.USER, variable, value, SetVarType.SET_USER_DEFINED_VAR);
+ }
+
+ @Override
+ public void analyze(Analyzer analyzer) {
+ Expr expression = getValue();
+ if (expression instanceof NullLiteral) {
+ setResult(NullLiteral.create(ScalarType.NULL));
+ } else if (expression instanceof LiteralExpr) {
+ setResult((LiteralExpr) expression);
Review Comment:
do we easy to support other expression? such as `1 + 1` or `@a + 1` or `concat(@4, "xxx")`?
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SetUserDefinedVar.java:
##########
@@ -0,0 +1,38 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+
+public class SetUserDefinedVar extends SetVar {
+ public SetUserDefinedVar(String variable, Expr value) {
+ super(SetType.USER, variable, value, SetVarType.SET_USER_DEFINED_VAR);
+ }
+
+ @Override
+ public void analyze(Analyzer analyzer) {
+ Expr expression = getValue();
+ if (expression instanceof NullLiteral) {
+ setResult(NullLiteral.create(ScalarType.NULL));
+ } else if (expression instanceof LiteralExpr) {
+ setResult((LiteralExpr) expression);
+ } else {
+ //TODO : compute value from query statement
Review Comment:
should we need to throw exception now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Reminiscent commented on a diff in pull request #20334: [feature](optimizer): support user defined variable
Posted by "Reminiscent (via GitHub)" <gi...@apache.org>.
Reminiscent commented on code in PR #20334:
URL: https://github.com/apache/doris/pull/20334#discussion_r1217808848
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -989,7 +989,8 @@ public TExpr treeToThrift() {
// Hack to ensure BE never sees TYPE_NULL. If an expr makes it this far without
// being cast to a non-NULL type, the type doesn't matter and we can cast it
// arbitrarily.
- Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef);
+ Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef
+ || this instanceof VariableExpr);
Review Comment:
Because when we `set @a=null` and use the `@a` in the statement, for example, `select @a ....`. The `@a` will be built as `VariableExpr` not the `NullLiteral`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Reminiscent commented on pull request #20334: [feature](optimizer): support user defined variable
Posted by "Reminiscent (via GitHub)" <gi...@apache.org>.
Reminiscent commented on PR #20334:
URL: https://github.com/apache/doris/pull/20334#issuecomment-1577847900
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #20334: [feature](optimizer): support user defined variable
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #20334:
URL: https://github.com/apache/doris/pull/20334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org