You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/05/05 21:54:39 UTC
[GitHub] [spark] pan3793 opened a new pull request, #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
pan3793 opened a new pull request, #41070:
URL: https://github.com/apache/spark/pull/41070
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add a new method `createTableReserveSchemaNullability` in `Table`, to allow the DataSource implementation to declare whether they need to reserve schema nullability on CTAS/RTAS.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
SPARK-28837 forcibly uses the nullable schema on CTAS/RTAS, which seems too aggressive:
1. The existing matured RDBMSs have different behaviors for reserving schema nullability on CTAS/RTAS, as mentioned in #25536, PostgreSQL forcibly uses the nullable schema, but MySQL respects the query's output schema nullability.
2. Some OLAP systems(e.g. ClickHouse) are perf-sensitive for nullable, and have strict restrictions on table schema, e.g. the primary keys are not allowed to be nullable.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, this PR adds a new to DSv2 API, but the default implementation reserves the backward compatibility.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UTs are updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #41070:
URL: https://github.com/apache/spark/pull/41070#discussion_r1187241024
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3261,3 +3278,7 @@ class FakeV2Provider extends SimpleTableProvider {
throw new UnsupportedOperationException("Unnecessary for DDL tests")
}
}
+
+class TestCreateTableReserveSchemaNullabilityCatalog extends InMemoryCatalog {
Review Comment:
Maybe "ReserveSchemaNullabilityCatalog"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41070:
URL: https://github.com/apache/spark/pull/41070#discussion_r1187015154
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -199,6 +199,14 @@ default Table createTable(
return createTable(ident, CatalogV2Util.v2ColumnsToStructType(columns), partitions, properties);
}
+ /**
+ * Return whether to reserve schema nullability of query output or forcibly use nullable schema
+ * on creating table implicitly, e.g. CTAS/RTAS.
+ */
+ default boolean createTableReserveSchemaNullability() {
Review Comment:
how about
```
/**
* If true, mark all the fields of the query schema as nullable when executing
* CREATE/REPLACE TABLE ... AS SELECT ... and creating the table.
*/
default boolean useNullableQuerySchema
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #41070:
URL: https://github.com/apache/spark/pull/41070#discussion_r1187243267
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3261,3 +3278,7 @@ class FakeV2Provider extends SimpleTableProvider {
throw new UnsupportedOperationException("Unnecessary for DDL tests")
}
}
+
+class TestCreateTableReserveSchemaNullabilityCatalog extends InMemoryCatalog {
Review Comment:
changed to "ReserveSchemaNullabilityCatalog"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #41070:
URL: https://github.com/apache/spark/pull/41070#discussion_r1187025603
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -199,6 +199,14 @@ default Table createTable(
return createTable(ident, CatalogV2Util.v2ColumnsToStructType(columns), partitions, properties);
}
+ /**
+ * Return whether to reserve schema nullability of query output or forcibly use nullable schema
+ * on creating table implicitly, e.g. CTAS/RTAS.
+ */
+ default boolean createTableReserveSchemaNullability() {
Review Comment:
Good suggestion, changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #41070:
URL: https://github.com/apache/spark/pull/41070#discussion_r1187238610
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3261,3 +3278,7 @@ class FakeV2Provider extends SimpleTableProvider {
throw new UnsupportedOperationException("Unnecessary for DDL tests")
}
}
+
+class TestCreateTableReserveSchemaNullabilityCatalog extends InMemoryCatalog {
Review Comment:
I means the name seems too long. Could you rename it with simple one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #41070:
URL: https://github.com/apache/spark/pull/41070#discussion_r1187212022
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3261,3 +3278,7 @@ class FakeV2Provider extends SimpleTableProvider {
throw new UnsupportedOperationException("Unnecessary for DDL tests")
}
}
+
+class TestCreateTableReserveSchemaNullabilityCatalog extends InMemoryCatalog {
Review Comment:
How about `ForbidSchemaNullabilityCatalog` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #41070:
URL: https://github.com/apache/spark/pull/41070#issuecomment-1539748021
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #41070:
URL: https://github.com/apache/spark/pull/41070#issuecomment-1536830449
cc @cloud-fan @sunchao @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #41070:
URL: https://github.com/apache/spark/pull/41070#discussion_r1187231654
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3261,3 +3278,7 @@ class FakeV2Provider extends SimpleTableProvider {
throw new UnsupportedOperationException("Unnecessary for DDL tests")
}
}
+
+class TestCreateTableReserveSchemaNullabilityCatalog extends InMemoryCatalog {
Review Comment:
"forbid" seems not accurate here, would prefer to use "reserve" to represent respecting the query schema nullability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #41070: [SPARK-43390][SQL] DSv2 allows CTAS/RTAS to reserve schema nullability
URL: https://github.com/apache/spark/pull/41070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org